* [PATCH] atm:he - Change 0 to false for bool type variable initialization.
@ 2015-05-27 1:20 Shailendra Verma
2015-05-27 3:10 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Shailendra Verma @ 2015-05-27 1:20 UTC (permalink / raw)
To: Chas Williams, linux-atm-general, netdev; +Cc: linux-kernel, Shailendra Verma
The variable sdh is bool type so initializing it with false value
instead of 0.
Signed-off-by: Shailendra Verma <shailendra.capricorn@gmail.com>
---
drivers/atm/he.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/atm/he.c b/drivers/atm/he.c
index 93dca2e..eb5bebc 100644
--- a/drivers/atm/he.c
+++ b/drivers/atm/he.c
@@ -116,8 +116,8 @@ static bool disable64;
static short nvpibits = -1;
static short nvcibits = -1;
static short rx_skb_reserve = 16;
-static bool irq_coalesce = 1;
-static bool sdh = 0;
+static bool irq_coalesce = true;
+static bool sdh = false;
/* Read from EEPROM = 0000 0011b */
static unsigned int readtab[] = {
--
1.7.9.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] atm:he - Change 0 to false for bool type variable initialization.
2015-05-27 1:20 [PATCH] atm:he - Change 0 to false for bool type variable initialization Shailendra Verma
@ 2015-05-27 3:10 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2015-05-27 3:10 UTC (permalink / raw)
To: shailendra.capricorn; +Cc: 3chas3, linux-atm-general, netdev, linux-kernel
From: Shailendra Verma <shailendra.capricorn@gmail.com>
Date: Wed, 27 May 2015 06:50:18 +0530
> The variable sdh is bool type so initializing it with false value
> instead of 0.
>
> Signed-off-by: Shailendra Verma <shailendra.capricorn@gmail.com>
> ---
> drivers/atm/he.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/atm/he.c b/drivers/atm/he.c
> index 93dca2e..eb5bebc 100644
> --- a/drivers/atm/he.c
> +++ b/drivers/atm/he.c
> @@ -116,8 +116,8 @@ static bool disable64;
> static short nvpibits = -1;
> static short nvcibits = -1;
> static short rx_skb_reserve = 16;
> -static bool irq_coalesce = 1;
> -static bool sdh = 0;
> +static bool irq_coalesce = true;
> +static bool sdh = false;
You didn't understand my feedback.
I already applied your patch that handled the irq_coalesce issue,
so you have to submit a patch relative to that.
In fact, you should always test that your patch applied to my tree
before submitting it.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-05-27 3:10 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-05-27 1:20 [PATCH] atm:he - Change 0 to false for bool type variable initialization Shailendra Verma
2015-05-27 3:10 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).