* [PATCH net-next] qla4xxx: add a missing include
@ 2015-05-27 4:43 Eric Dumazet
2015-05-27 18:21 ` David Miller
0 siblings, 1 reply; 4+ messages in thread
From: Eric Dumazet @ 2015-05-27 4:43 UTC (permalink / raw)
To: David Miller; +Cc: netdev, linux-scsi
From: Eric Dumazet <edumzet@google.com>
vmalloc.h used to be included from include/net/inet_hashtables.h
but it is no longer the case.
Fixes: 095dc8e0c368 ("tcp: fix/cleanup inet_ehash_locks_alloc()")
Reported-by: kbuild test robot <fengguang.wu@intel.com>
Signed-off-by: Eric Dumazet <edumzet@google.com>
---
Given its broken in David net-next tree, its probably simpler
that David merges this fix directly ? Thanks !
drivers/scsi/qla4xxx/ql4_def.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/scsi/qla4xxx/ql4_def.h b/drivers/scsi/qla4xxx/ql4_def.h
index 8f6d0fb2cd807255a66e962c3cb7c4c8633d4d77..a7cfc270bd08a1f01867affc2dee0fc6b7611472 100644
--- a/drivers/scsi/qla4xxx/ql4_def.h
+++ b/drivers/scsi/qla4xxx/ql4_def.h
@@ -26,6 +26,7 @@
#include <linux/mutex.h>
#include <linux/aer.h>
#include <linux/bsg-lib.h>
+#include <linux/vmalloc.h>
#include <net/tcp.h>
#include <scsi/scsi.h>
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH net-next] qla4xxx: add a missing include
2015-05-27 4:43 [PATCH net-next] qla4xxx: add a missing include Eric Dumazet
@ 2015-05-27 18:21 ` David Miller
2015-05-27 18:33 ` James Bottomley
0 siblings, 1 reply; 4+ messages in thread
From: David Miller @ 2015-05-27 18:21 UTC (permalink / raw)
To: eric.dumazet; +Cc: netdev, linux-scsi
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Tue, 26 May 2015 21:43:44 -0700
> From: Eric Dumazet <edumzet@google.com>
>
> vmalloc.h used to be included from include/net/inet_hashtables.h
> but it is no longer the case.
>
> Fixes: 095dc8e0c368 ("tcp: fix/cleanup inet_ehash_locks_alloc()")
> Reported-by: kbuild test robot <fengguang.wu@intel.com>
> Signed-off-by: Eric Dumazet <edumzet@google.com>
> ---
> Given its broken in David net-next tree, its probably simpler
> that David merges this fix directly ? Thanks !
Yeah it's easiest if I just apply this to net-next, which I've just done,
thanks Eric.
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH net-next] qla4xxx: add a missing include
2015-05-27 18:21 ` David Miller
@ 2015-05-27 18:33 ` James Bottomley
2015-05-27 19:47 ` Eric Dumazet
0 siblings, 1 reply; 4+ messages in thread
From: James Bottomley @ 2015-05-27 18:33 UTC (permalink / raw)
To: David Miller; +Cc: eric.dumazet, netdev, linux-scsi
On Wed, 2015-05-27 at 14:21 -0400, David Miller wrote:
> From: Eric Dumazet <eric.dumazet@gmail.com>
> Date: Tue, 26 May 2015 21:43:44 -0700
>
> > From: Eric Dumazet <edumzet@google.com>
> >
> > vmalloc.h used to be included from include/net/inet_hashtables.h
> > but it is no longer the case.
> >
> > Fixes: 095dc8e0c368 ("tcp: fix/cleanup inet_ehash_locks_alloc()")
> > Reported-by: kbuild test robot <fengguang.wu@intel.com>
> > Signed-off-by: Eric Dumazet <edumzet@google.com>
> > ---
> > Given its broken in David net-next tree, its probably simpler
> > that David merges this fix directly ? Thanks !
>
> Yeah it's easiest if I just apply this to net-next, which I've just done,
> thanks Eric.
Fine with me. There's no point creating cross tree hassle for a simple
include problem.
James
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH net-next] qla4xxx: add a missing include
2015-05-27 18:33 ` James Bottomley
@ 2015-05-27 19:47 ` Eric Dumazet
0 siblings, 0 replies; 4+ messages in thread
From: Eric Dumazet @ 2015-05-27 19:47 UTC (permalink / raw)
To: James Bottomley; +Cc: David Miller, netdev, linux-scsi
On Wed, 2015-05-27 at 11:33 -0700, James Bottomley wrote:
> On Wed, 2015-05-27 at 14:21 -0400, David Miller wrote:
> > Yeah it's easiest if I just apply this to net-next, which I've just done,
> > thanks Eric.
>
> Fine with me. There's no point creating cross tree hassle for a simple
> include problem.
Note there are other drivers to fix, I'll try to submit patches for
them.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-05-27 19:48 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-05-27 4:43 [PATCH net-next] qla4xxx: add a missing include Eric Dumazet
2015-05-27 18:21 ` David Miller
2015-05-27 18:33 ` James Bottomley
2015-05-27 19:47 ` Eric Dumazet
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).