From: Joe Perches <joe@perches.com>
To: Nicholas Krause <xerofoify@gmail.com>
Cc: davem@davemloft.ne, brouer@redhat.com, edumazet@google.com,
ast@plumgrid.com, sd@queasysnail.net,
elfring@users.sourceforge.net, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] core: Convert the function process_ipcsec to the, return type bool
Date: Wed, 27 May 2015 18:47:52 -0700 [thread overview]
Message-ID: <1432777672.2846.190.camel@perches.com> (raw)
In-Reply-To: <1432775694-30144-1-git-send-email-xerofoify@gmail.com>
On Wed, 2015-05-27 at 21:14 -0400, Nicholas Krause wrote:
> This makes the function,process_ipsec have a return true
> of bool now due to only returning 1 or 0. In additon this
> changes this function's return statements to return true
> and false rather then 1 and 0 respectfully.
The patch subject title and the grammar in the commit message
could be improved, but other than that, it seems OK to me.
I would have written something like:
Subject: [PATCH] pktgen: Convert return type of process_ipsec to bool
It's used as a bool function, make it so.
Convert the return 1/0 to return true/false too.
Signed-off-by: etc...
parent reply other threads:[~2015-05-28 1:47 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <1432775694-30144-1-git-send-email-xerofoify@gmail.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1432777672.2846.190.camel@perches.com \
--to=joe@perches.com \
--cc=ast@plumgrid.com \
--cc=brouer@redhat.com \
--cc=davem@davemloft.ne \
--cc=edumazet@google.com \
--cc=elfring@users.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sd@queasysnail.net \
--cc=xerofoify@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).