From: Vadim Kochan <vadim4j@gmail.com>
To: netdev@vger.kernel.org
Cc: Vadim Kochan <vadim4j@gmail.com>
Subject: [PATCH iproute2] ss: Fix allocation of cong control alg name
Date: Fri, 29 May 2015 13:30:00 +0300 [thread overview]
Message-ID: <1432895400-12266-1-git-send-email-vadim4j@gmail.com> (raw)
From: Vadim Kochan <vadim4j@gmail.com>
Use strdup instead of malloc, and get rid of bad strcpy.
Signed-off-by: Vadim Kochan <vadim4j@gmail.com>
---
misc/ss.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/misc/ss.c b/misc/ss.c
index 347e3a1..a719466 100644
--- a/misc/ss.c
+++ b/misc/ss.c
@@ -1908,8 +1908,7 @@ static void tcp_show_info(const struct nlmsghdr *nlh, struct inet_diag_msg *r,
if (tb[INET_DIAG_CONG]) {
const char *cong_attr = rta_getattr_str(tb[INET_DIAG_CONG]);
- s.cong_alg = malloc(strlen(cong_attr + 1));
- strcpy(s.cong_alg, cong_attr);
+ s.cong_alg = strdup(cong_attr);
}
if (TCPI_HAS_OPT(info, TCPI_OPT_WSCALE)) {
--
2.3.1
next reply other threads:[~2015-05-29 10:31 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-29 10:30 Vadim Kochan [this message]
2015-05-29 11:04 ` [PATCH iproute2] ss: Fix allocation of cong control alg name Eric Dumazet
2015-05-29 11:11 ` Daniel Borkmann
2015-05-29 12:53 ` Vadim Kochan
2015-05-29 15:15 ` Eric Dumazet
2015-05-29 11:09 ` Daniel Borkmann
2015-05-29 16:17 ` Guzman Mosqueda, Jose R
2015-05-29 16:48 ` Daniel Borkmann
2015-06-25 3:31 ` Stephen Hemminger
2015-06-25 7:12 ` Daniel Borkmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1432895400-12266-1-git-send-email-vadim4j@gmail.com \
--to=vadim4j@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).