Re: [PATCH net V1] ethtool: Support for configurable RSS hash function

[Ben Hutchings <ben@decadent.org.uk>]

[-- Attachment #1: Type: text/plain, Size: 1529 bytes --]

On Tue, 2015-05-05 at 18:48 +0300, Amir Vadai wrote:
> On Mon, Apr 27, 2015 at 2:22 PM, Amir Vadai <amirv@mellanox.com> wrote:
> > From: Eyal Perry <eyalpe@mellanox.com>
> >
> > This ethtool patch adds support to set and get the current RSS hash
> > function for the device through through the new hfunc field in the
> > ethtool_rxfh struct. Kernel supported hash function names are queried
> > with ETHTOOL_GSTRINGS (value 0 is reserved and skipped).
> >
> > Although currently no device supports a combination of hash
> > functions/attributes, this ethtool implementation will support it. Both in the
> > set and in the get.
> > The device driver declares the functions and/or attributes that it supports,
> > and ethtool will show it correctly and enable the user to set those
> > combinations.
> > If a combination is not supported - the device driver will fail the operation
> > and ethtool will print an error message.
> >
> > Signed-off-by: Eyal Perry <eyalpe@mellanox.com>
> > Signed-off-by: Amir Vadai <amirv@mellanox.com>
> > ---
> > Changes from V1:
> > - Fixed some English mistakes
> > - Fixed the complicated way to write '= req_hfunc;'...
> > - Better support in combination of hash functions/attributes
> 
> Ben Hi,
> 
> Could you take a look at this patch?

Didn't we agree that only one hash function should be selected at once?
Can you send a new version that implements that?

Ben.

-- 
Ben Hutchings
Reality is just a crutch for people who can't handle science fiction.

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 811 bytes --]