From: Ben Hutchings <ben@decadent.org.uk>
To: Ivan Mikhaylov <ivan@ru.ibm.com>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCH] ethtool: changes of emac_regs structure accordingly within driver emac_regs structure.
Date: Sun, 31 May 2015 21:57:27 +0100 [thread overview]
Message-ID: <1433105847.6319.139.camel@decadent.org.uk> (raw)
In-Reply-To: <20150521190917.6971eb09@fr-ThinkPad-W520>
[-- Attachment #1: Type: text/plain, Size: 882 bytes --]
On Thu, 2015-05-21 at 19:09 +0400, Ivan Mikhaylov wrote:
> In ibm_emac.c in ethtool size of emac structure which passing through to driver
> is nailed down and not correlating with current emac_regs structure.
>
> Signed-off-by: Ivan Mikhaylov <ivan@ru.ibm.com>
[...]
This is not backward-compatible. It ought to be possible to mix and
match old and new ethtool and driver, except for the EMAC4SYNC case
which has been broken up until now.
Using the new definition of struct emac_regs, I think the driver and
ethtool need to agree that the MAC register dump sizes are:
EMAC: offsetof(struct emac_regs, u1)
EMAC4: offsetof(struct emac_regs, u1.emac4) + sizeof(p->u1.emac4)
EMAC4SYNC: offsetof(struct emac_regs, u1.emac4sync) + sizeof(p->u1.emac4sync)
Ben.
--
Ben Hutchings
Reality is just a crutch for people who can't handle science fiction.
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 811 bytes --]
next prev parent reply other threads:[~2015-05-31 20:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-21 15:09 [PATCH] ethtool: changes of emac_regs structure accordingly within driver emac_regs structure Ivan Mikhaylov
2015-05-31 20:57 ` Ben Hutchings [this message]
2015-06-01 12:30 ` Ivan Mikhaylov
2015-06-01 18:11 ` Ben Hutchings
2015-06-03 14:28 ` Ivan Mikhaylov
2015-06-23 15:28 ` Ivan Mikhaylov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1433105847.6319.139.camel@decadent.org.uk \
--to=ben@decadent.org.uk \
--cc=davem@davemloft.net \
--cc=ivan@ru.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox