From: Oliver Neukum <oneukum-IBi9RG/b67k@public.gmane.org>
To: Enrico Mioso <mrkiko.rs-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: Greg KH <greg-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>,
linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
youtux-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org
Subject: Re: [cdc_ncm] guidance and help refactoring cdc_ncm
Date: Mon, 01 Jun 2015 09:48:26 +0200 [thread overview]
Message-ID: <1433144906.1557.2.camel@suse.com> (raw)
In-Reply-To: <alpine.LNX.2.20.1506010818110.3158-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
On Mon, 2015-06-01 at 08:53 +0200, Enrico Mioso wrote:
> A 32-bit version of the driver (talking 32-bit NCM) is here:
> http://www.gstorm.eu/cdc_ncm.c
> I modified the original driver with the help of a very talented friend.
> It works: but there seem to be no real reasons to implement this properly. We
> did this in a consistent effort to understand what was wrong, and here it is.
Well, you are really talking about two different things here.
Do we ever fail because we only do 16 bit as opposed to 32 bit?
Your 32 bit driver looks good, but it raises the question of what to do
if this test:
if (le16_to_cpu(ctx->ncm_parm.bmNtbFormatsSupported) &
USB_CDC_NCM_NTB32_SUPPORTED) {
fails. Otherwise it looks ready for merging.
Regards
Oliver
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2015-06-01 7:48 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-31 14:37 [cdc_ncm] guidance and help refactoring cdc_ncm Enrico Mioso
[not found] ` <alpine.LNX.2.20.1505311628420.16456-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2015-06-01 0:59 ` Greg KH
[not found] ` <20150601005917.GB5320-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>
2015-06-01 6:53 ` Enrico Mioso
[not found] ` <alpine.LNX.2.20.1506010818110.3158-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2015-06-01 7:48 ` Oliver Neukum [this message]
[not found] ` <1433144906.1557.2.camel-IBi9RG/b67k@public.gmane.org>
2015-06-01 8:24 ` Enrico Mioso
2015-06-01 10:49 ` Oliver Neukum
[not found] ` <1433155778.1884.12.camel-l3A5Bk7waGM@public.gmane.org>
2015-06-01 11:41 ` Enrico Mioso
2015-06-01 12:00 ` Oliver Neukum
[not found] ` <1433160022.1884.18.camel-IBi9RG/b67k@public.gmane.org>
2015-06-01 12:08 ` Enrico Mioso
2015-06-02 5:46 ` [RFC cdc_ncm] introducing allocation mode Enrico Mioso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1433144906.1557.2.camel@suse.com \
--to=oneukum-ibi9rg/b67k@public.gmane.org \
--cc=greg-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org \
--cc=linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=mrkiko.rs-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=youtux-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).