netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH net v3 0/2] mpls: fix route del errors on wrong scope and type
@ 2015-06-02  6:29 Roopa Prabhu
  0 siblings, 0 replies; only message in thread
From: Roopa Prabhu @ 2015-06-02  6:29 UTC (permalink / raw)
  To: ebiederm, stephen; +Cc: davem, rshearma, netdev, vivek

From: Roopa Prabhu <roopa@cumulusnetworks.com>

This patch fixes incorrect -EINVAL errors due to invalid
scope and type during mpls route deletes.

$ip -f mpls route add 100 as 200 via inet 10.1.1.2 dev swp1

$ip -f mpls route show
100 as to 200 via inet 10.1.1.2 dev swp1

$ip -f mpls route del 100 as 200 via inet 10.1.1.2 dev swp1
RTNETLINK answers: Invalid argument

$ip -f mpls route del 100
RTNETLINK answers: Invalid argument

After patch:

$ip -f mpls route show
100 as to 200 via inet 10.1.1.2 dev swp1

$ip -f mpls route del 100 as 200 via inet 10.1.1.2 dev swp1

$ip -f mpls route show

Reported-by: Vivek Venkataraman <vivek@cumulusnetworks.com>
Signed-off-by: Vivek Venkataraman <vivek@cumulusnetworks.com>
Signed-off-by: Roopa Prabhu <roopa@cumulusnetworks.com>
---

v2: split the fix between iproute2 and kernel as suggested by
	Eric Biederman

v3: fix if condition indent

Roopa Prabhu (2):
  iproute2: mpls: always set type as RTN_UNICAST for route
  mpls: fix mpls route deletes to not check for route scope

 net/mpls/af_mpls.c |    7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

-- 
1.7.10.4

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2015-06-02  6:29 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-06-02  6:29 [PATCH net v3 0/2] mpls: fix route del errors on wrong scope and type Roopa Prabhu

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).