netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Antonio Quartulli <antonio@meshcoding.com>
To: davem@davemloft.net
Cc: netdev@vger.kernel.org, b.a.t.m.a.n@lists.open-mesh.org,
	Markus Pargmann <mpa@pengutronix.de>,
	Marek Lindner <mareklindner@neomailbox.ch>,
	Antonio Quartulli <antonio@meshcoding.com>
Subject: [PATCH 12/12] batman-adv: Remove unnecessary ret variable in algo_register
Date: Wed,  3 Jun 2015 16:14:08 +0200	[thread overview]
Message-ID: <1433340848-1682-13-git-send-email-antonio@meshcoding.com> (raw)
In-Reply-To: <1433340848-1682-1-git-send-email-antonio@meshcoding.com>

From: Markus Pargmann <mpa@pengutronix.de>

Remove ret variable and all jumps.

Signed-off-by: Markus Pargmann <mpa@pengutronix.de>
Signed-off-by: Marek Lindner <mareklindner@neomailbox.ch>
Signed-off-by: Antonio Quartulli <antonio@meshcoding.com>
---
 net/batman-adv/main.c | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)

diff --git a/net/batman-adv/main.c b/net/batman-adv/main.c
index 49f07e1..548e405 100644
--- a/net/batman-adv/main.c
+++ b/net/batman-adv/main.c
@@ -544,17 +544,14 @@ int batadv_algo_register(struct batadv_algo_ops *bat_algo_ops)
 int batadv_algo_select(struct batadv_priv *bat_priv, char *name)
 {
 	struct batadv_algo_ops *bat_algo_ops;
-	int ret = -EINVAL;
 
 	bat_algo_ops = batadv_algo_get(name);
 	if (!bat_algo_ops)
-		goto out;
+		return -EINVAL;
 
 	bat_priv->bat_algo_ops = bat_algo_ops;
-	ret = 0;
 
-out:
-	return ret;
+	return 0;
 }
 
 int batadv_algo_seq_print_text(struct seq_file *seq, void *offset)
-- 
2.4.2

  parent reply	other threads:[~2015-06-03 14:21 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-03 14:13 pull request: batman-adv 20150603 Antonio Quartulli
2015-06-03 14:13 ` [PATCH 01/12] batman-adv: iv_ogm_aggregate_new, simplify error handling Antonio Quartulli
2015-06-03 14:13 ` [PATCH 02/12] batman-adv: iv_ogm_queue_add, Simplify expressions Antonio Quartulli
2015-06-03 14:13 ` [PATCH 03/12] batman-adv: iv_ogm_orig_update, style, add missing brackets Antonio Quartulli
2015-06-03 14:14 ` [PATCH 04/12] batman-adv: iv_ogm, Fix dup_status comment Antonio Quartulli
2015-06-03 14:14 ` [PATCH 05/12] batman-adv: iv_ogm, fix coding style Antonio Quartulli
2015-06-03 14:14 ` [PATCH 06/12] batman-adv: iv_ogm, fix comment function name Antonio Quartulli
2015-06-03 14:14 ` [PATCH 07/12] batman-adv: types, Fix comment on bcast_own Antonio Quartulli
2015-06-03 14:14 ` [PATCH 08/12] batman-adv: Remove unnecessary check for orig_ifinfo not NULL Antonio Quartulli
2015-06-03 14:14 ` [PATCH 09/12] batman-adv: main, Convert is_my_mac() to bool Antonio Quartulli
2015-06-03 14:14 ` [PATCH 10/12] batman-adv: main, batadv_compare_eth return bool Antonio Quartulli
2015-06-03 14:14 ` [PATCH 11/12] batman-adv: Remove unnecessary ret variable Antonio Quartulli
2015-06-03 14:14 ` Antonio Quartulli [this message]
2015-06-04  3:23 ` pull request: batman-adv 20150603 David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1433340848-1682-13-git-send-email-antonio@meshcoding.com \
    --to=antonio@meshcoding.com \
    --cc=b.a.t.m.a.n@lists.open-mesh.org \
    --cc=davem@davemloft.net \
    --cc=mareklindner@neomailbox.ch \
    --cc=mpa@pengutronix.de \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).