From: "Keller, Jacob E" <jacob.e.keller@intel.com>
To: "alexander.h.duyck@redhat.com" <alexander.h.duyck@redhat.com>
Cc: "davem@davemloft.net" <davem@davemloft.net>,
"Kirsher, Jeffrey T" <jeffrey.t.kirsher@intel.com>,
"intel-wired-lan@lists.osuosl.org"
<intel-wired-lan@lists.osuosl.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [Intel-wired-lan] [PATCH] fm10k: Fix missing braces after if statement
Date: Thu, 4 Jun 2015 23:28:09 +0000 [thread overview]
Message-ID: <1433460464.1500.4.camel@intel.com> (raw)
In-Reply-To: <20150604015219.2895.80478.stgit@ahduyck-vm-fedora22>
Acked-by: Jacob Keller <jacob.e.keller@intel.com>
Thanks Alex.
Regards,
Jake
On Wed, 2015-06-03 at 18:53 -0700, Alexander Duyck wrote:
> While reviewing the code I noticed that one of the commits added an if
> statement followed by a for loop, but the if statement was missing the
> braces around the loop. This change corrects the coding style error.
>
> Signed-off-by: Alexander Duyck <alexander.h.duyck@redhat.com>
> ---
> drivers/net/ethernet/intel/fm10k/fm10k_ethtool.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/intel/fm10k/fm10k_ethtool.c b/drivers/net/ethernet/intel/fm10k/fm10k_ethtool.c
> index 4b9d9f88af70..a9670e00cf03 100644
> --- a/drivers/net/ethernet/intel/fm10k/fm10k_ethtool.c
> +++ b/drivers/net/ethernet/intel/fm10k/fm10k_ethtool.c
> @@ -143,12 +143,13 @@ static void fm10k_get_strings(struct net_device *dev, u32 stringset, u8 *data)
> p += ETH_GSTRING_LEN;
> }
>
> - if (interface->hw.mac.type != fm10k_mac_vf)
> + if (interface->hw.mac.type != fm10k_mac_vf) {
> for (i = 0; i < FM10K_PF_STATS_LEN; i++) {
> memcpy(p, fm10k_gstrings_pf_stats[i].stat_string,
> ETH_GSTRING_LEN);
> p += ETH_GSTRING_LEN;
> }
> + }
>
> for (i = 0; i < interface->hw.mac.max_queues; i++) {
> sprintf(p, "tx_queue_%u_packets", i);
>
> _______________________________________________
> Intel-wired-lan mailing list
> Intel-wired-lan@lists.osuosl.org
> http://lists.osuosl.org/mailman/listinfo/intel-wired-lan
prev parent reply other threads:[~2015-06-04 23:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-04 1:53 [PATCH] fm10k: Fix missing braces after if statement Alexander Duyck
2015-06-04 6:57 ` David Miller
2015-06-04 12:37 ` Jeff Kirsher
2015-06-04 23:28 ` Keller, Jacob E [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1433460464.1500.4.camel@intel.com \
--to=jacob.e.keller@intel.com \
--cc=alexander.h.duyck@redhat.com \
--cc=davem@davemloft.net \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jeffrey.t.kirsher@intel.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).