From: Ivan Vecera <ivecera@redhat.com>
To: netdev@vger.kernel.org
Cc: rasesh.mody@qlogic.com
Subject: [PATCH net-next 15/19] bna: remove useless pointer assignment
Date: Wed, 10 Jun 2015 18:43:21 +0200 [thread overview]
Message-ID: <1433954605-22813-16-git-send-email-ivecera@redhat.com> (raw)
In-Reply-To: <1433954605-22813-1-git-send-email-ivecera@redhat.com>
Pointer cmpl used to iterate through completion entries is updated at
the beginning of while loop as well as at the end. The update at the end
of the loop is useless.
Signed-off-by: Ivan Vecera <ivecera@redhat.com>
---
drivers/net/ethernet/brocade/bna/bnad.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/net/ethernet/brocade/bna/bnad.c b/drivers/net/ethernet/brocade/bna/bnad.c
index e871e27..aea585b 100644
--- a/drivers/net/ethernet/brocade/bna/bnad.c
+++ b/drivers/net/ethernet/brocade/bna/bnad.c
@@ -724,7 +724,6 @@ next:
cmpl->valid = 0;
BNA_QE_INDX_INC(ccb->producer_index, ccb->q_depth);
}
- cmpl = &cq[ccb->producer_index];
}
napi_gro_flush(&rx_ctrl->napi, false);
--
2.3.6
next prev parent reply other threads:[~2015-06-10 16:43 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-10 16:43 [PATCH net-next 00/19] bna: clean-up Ivan Vecera
2015-06-10 16:43 ` [PATCH net-next 01/19] bna: use ether_addr_copy instead of memcpy Ivan Vecera
2015-06-10 17:57 ` Joe Perches
2015-06-11 13:31 ` Ivan Vecera
2015-06-10 16:43 ` [PATCH net-next 02/19] bna: get rid of mac_t Ivan Vecera
2015-06-10 16:43 ` [PATCH net-next 03/19] bna: replace pragma(pack) with attribute __packed Ivan Vecera
2015-06-10 16:43 ` [PATCH net-next 04/19] bna: get rid of duplicate and unused macros Ivan Vecera
2015-06-10 16:43 ` [PATCH net-next 05/19] bna: use BIT(x) instead of (1 << x) Ivan Vecera
2015-06-10 16:43 ` [PATCH net-next 06/19] bna: remove unused cbfn parameter Ivan Vecera
2015-06-10 16:43 ` [PATCH net-next 07/19] bna: remove pause_cbfn from struct bna_enet Ivan Vecera
2015-06-10 16:43 ` [PATCH net-next 08/19] bna: remove oper_state_cbfn from struct bna_rxf Ivan Vecera
2015-06-10 16:43 ` [PATCH net-next 09/19] bna: remove prio_change_cbfn oper_state_cbfn from struct bna_tx Ivan Vecera
2015-06-10 16:43 ` [PATCH net-next 10/19] bna: remove RXF_E_PAUSE and RXF_E_RESUME events Ivan Vecera
2015-06-10 16:43 ` [PATCH net-next 11/19] bna: remove paused from bna_rx_config and flags from bna_rxf Ivan Vecera
2015-06-10 16:43 ` [PATCH net-next 12/19] bna: remove TX_E_PRIO_CHANGE event and BNA_TX_F_PRIO_CHANGED flag Ivan Vecera
2015-06-10 16:43 ` [PATCH net-next 13/19] bna: correct comparisons/assignments to bool Ivan Vecera
2015-06-10 16:43 ` [PATCH net-next 14/19] bna: use memdup_user to copy userspace buffers Ivan Vecera
2015-06-10 16:43 ` Ivan Vecera [this message]
2015-06-10 16:43 ` [PATCH net-next 16/19] bna: get rid of private macros for manipulation with lists Ivan Vecera
2015-06-10 16:43 ` [PATCH net-next 17/19] bna: use list_for_each_entry where appropriate Ivan Vecera
2015-06-10 16:43 ` [PATCH net-next 18/19] bna: fix timeout API argument type Ivan Vecera
2015-06-10 16:43 ` [PATCH net-next 19/19] bna: use netdev_* and dev_* instead of printk and pr_* Ivan Vecera
2015-06-10 20:29 ` Joe Perches
2015-06-11 9:43 ` Ivan Vecera
2015-06-11 16:36 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1433954605-22813-16-git-send-email-ivecera@redhat.com \
--to=ivecera@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=rasesh.mody@qlogic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).