From: sfeldma@gmail.com
To: netdev@vger.kernel.org
Cc: jiri@resnulli.us, bblanco@plumgrid.com
Subject: [PATCH net-next] switchdev: fix BUG when port driver doesn't support set attr op
Date: Wed, 10 Jun 2015 13:56:02 -0700 [thread overview]
Message-ID: <1433969762-22406-1-git-send-email-sfeldma@gmail.com> (raw)
From: Scott Feldman <sfeldma@gmail.com>
Fix a BUG() where CONFIG_NET_SWITCHDEV is set but the driver for a bridged
port does not support switchdec_port_attr_set op. Don't BUG() if
-EOPNOTSUPP is returned.
Signed-off-by: Scott Feldman <sfeldma@gmail.com>
Reported-by: Brenden Blanco <bblanco@plumgrid.com>
---
net/switchdev/switchdev.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/switchdev/switchdev.c b/net/switchdev/switchdev.c
index e008057..99bced4 100644
--- a/net/switchdev/switchdev.c
+++ b/net/switchdev/switchdev.c
@@ -103,7 +103,7 @@ static void switchdev_port_attr_set_work(struct work_struct *work)
rtnl_lock();
err = switchdev_port_attr_set(asw->dev, &asw->attr);
- BUG_ON(err);
+ BUG_ON(err && err != -EOPNOTSUPP);
rtnl_unlock();
dev_put(asw->dev);
--
1.7.10.4
next reply other threads:[~2015-06-10 20:54 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-10 20:56 sfeldma [this message]
2015-06-10 21:13 ` [PATCH net-next] switchdev: fix BUG when port driver doesn't support set attr op Andy Gospodarek
2015-06-10 21:25 ` David Ahern
2015-06-10 21:47 ` Scott Feldman
2015-06-10 21:51 ` David Ahern
2015-06-10 22:00 ` Scott Feldman
2015-06-11 6:16 ` Jiri Pirko
2015-06-11 15:03 ` Scott Feldman
2015-06-11 15:34 ` Jiri Pirko
2015-06-11 7:06 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1433969762-22406-1-git-send-email-sfeldma@gmail.com \
--to=sfeldma@gmail.com \
--cc=bblanco@plumgrid.com \
--cc=jiri@resnulli.us \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox