From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
To: Richard Cochran <richardcochran@gmail.com>
Cc: netdev@vger.kernel.org, David Miller <davem@davemloft.net>,
Jacob Keller <jacob.e.keller@intel.com>,
Matthew Vick <matthew.vick@intel.com>
Subject: Re: [PATCH net] net: igb: fix the start time for periodic output signals
Date: Thu, 11 Jun 2015 15:59:05 -0700 [thread overview]
Message-ID: <1434063545.3530.11.camel@intel.com> (raw)
In-Reply-To: <1434027090-26866-1-git-send-email-richardcochran@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 629 bytes --]
On Thu, 2015-06-11 at 14:51 +0200, Richard Cochran wrote:
> When programming the start of a periodic output, the code wrongly
> places
> the seconds value into the "low" register and the nanoseconds into the
> "high" register. Even though this is backwards, it slipped through my
> testing, because the re-arming code in the interrupt service routine
> is
> correct, and the signal does appear starting with the second edge.
>
> This patch fixes the issue by programming the registers correctly.
>
> Signed-off-by: Richard Cochran <richardcochran@gmail.com>
Acked-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2015-06-11 22:59 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-11 12:51 [PATCH net] net: igb: fix the start time for periodic output signals Richard Cochran
2015-06-11 12:53 ` Richard Cochran
2015-06-11 22:56 ` David Miller
2015-06-11 22:58 ` Jeff Kirsher
2015-06-11 17:05 ` Keller, Jacob E
2015-06-11 22:59 ` Jeff Kirsher [this message]
2015-06-11 23:04 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1434063545.3530.11.camel@intel.com \
--to=jeffrey.t.kirsher@intel.com \
--cc=davem@davemloft.net \
--cc=jacob.e.keller@intel.com \
--cc=matthew.vick@intel.com \
--cc=netdev@vger.kernel.org \
--cc=richardcochran@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).