* [PATCH net-next] rocker: gaurd against NULL rocker_port when removing ports
@ 2015-06-13 4:09 sfeldma
2015-06-13 9:07 ` Jiri Pirko
2015-06-15 23:04 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: sfeldma @ 2015-06-13 4:09 UTC (permalink / raw)
To: netdev; +Cc: jiri
From: Scott Feldman <sfeldma@gmail.com>
The ports array is filled in as ports are probed, but if probing doesn't
finish, we need to stop only those ports that where probed successfully.
Check the ports array for NULL to skip un-probed ports when stopping.
Signed-off-by: Scott Feldman <sfeldma@gmail.com>
---
drivers/net/ethernet/rocker/rocker.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/net/ethernet/rocker/rocker.c b/drivers/net/ethernet/rocker/rocker.c
index 819289e..c6a6e3c 100644
--- a/drivers/net/ethernet/rocker/rocker.c
+++ b/drivers/net/ethernet/rocker/rocker.c
@@ -4802,6 +4802,8 @@ static void rocker_remove_ports(const struct rocker *rocker)
for (i = 0; i < rocker->port_count; i++) {
rocker_port = rocker->ports[i];
+ if (!rocker_port)
+ continue;
rocker_port_ig_tbl(rocker_port, SWITCHDEV_TRANS_NONE,
ROCKER_OP_FLAG_REMOVE);
unregister_netdev(rocker_port->dev);
--
1.7.10.4
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH net-next] rocker: gaurd against NULL rocker_port when removing ports
2015-06-13 4:09 [PATCH net-next] rocker: gaurd against NULL rocker_port when removing ports sfeldma
@ 2015-06-13 9:07 ` Jiri Pirko
2015-06-15 23:04 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Jiri Pirko @ 2015-06-13 9:07 UTC (permalink / raw)
To: sfeldma; +Cc: netdev
Sat, Jun 13, 2015 at 06:09:44AM CEST, sfeldma@gmail.com wrote:
>From: Scott Feldman <sfeldma@gmail.com>
>
>The ports array is filled in as ports are probed, but if probing doesn't
>finish, we need to stop only those ports that where probed successfully.
>Check the ports array for NULL to skip un-probed ports when stopping.
>
>Signed-off-by: Scott Feldman <sfeldma@gmail.com>
Acked-by: Jiri Pirko <jiri@resnulli.us>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] rocker: gaurd against NULL rocker_port when removing ports
2015-06-13 4:09 [PATCH net-next] rocker: gaurd against NULL rocker_port when removing ports sfeldma
2015-06-13 9:07 ` Jiri Pirko
@ 2015-06-15 23:04 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2015-06-15 23:04 UTC (permalink / raw)
To: sfeldma; +Cc: netdev, jiri
From: sfeldma@gmail.com
Date: Fri, 12 Jun 2015 21:09:44 -0700
> From: Scott Feldman <sfeldma@gmail.com>
>
> The ports array is filled in as ports are probed, but if probing doesn't
> finish, we need to stop only those ports that where probed successfully.
> Check the ports array for NULL to skip un-probed ports when stopping.
>
> Signed-off-by: Scott Feldman <sfeldma@gmail.com>
Applied.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-06-15 23:04 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-06-13 4:09 [PATCH net-next] rocker: gaurd against NULL rocker_port when removing ports sfeldma
2015-06-13 9:07 ` Jiri Pirko
2015-06-15 23:04 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).