* [BUG ?] irda: via-ircc: condition with no effect
@ 2015-06-13 10:47 Nicholas Mc Guire
0 siblings, 0 replies; only message in thread
From: Nicholas Mc Guire @ 2015-06-13 10:47 UTC (permalink / raw)
To: Samuel Ortiz; +Cc: netdev, linux-kernel
From: Nicholas Mc Guire <hofrat@osadl.org>
scanning for trivial bug-patters with coccinelle spatches returned:
./drivers/net/irda/via-ircc.c:598
WARNING: condition with no effect (if branch == else)
This code was added prior to the transition to git (Linux-2.6.12-rc2) so
I was not really able to track back what the intent was.
drivers/net/irda/via-ircc.c - line numbers from 4.1-rc7
598 if (IsSIROn(iobase)) { //sir
599 EnGPIOtoRX2(iobase, OFF);
600 WriteGIO(iobase, OFF);
601 EnRX2(iobase, OFF); //sir to rx2
602 } else { // fir mir
603 EnGPIOtoRX2(iobase, OFF);
604 WriteGIO(iobase, OFF);
605 EnRX2(iobase, OFF); //fir to rx
606 }
Given the comments that indicate that the if/else case actually are
different this may be a bug - if not the comments might need fixing.
thx!
hofrat
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2015-06-13 10:47 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-06-13 10:47 [BUG ?] irda: via-ircc: condition with no effect Nicholas Mc Guire
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).