[PATCH iproute2 net-next 0/3] iplink_bridge: add support for ageing_time, priority and stp_state

[PATCH iproute2 net-next 0/3] iplink_bridge: add support for ageing_time, priority and stp_state

[Nikolay Aleksandrov]

Hi,
Three months ago support was added to be able to set ageing_time,
priority and stp_state via netlink by commit:
af615762e972 ("bridge: add ageing_time, stp_state, priority over netlink")
This patch-set adds support for iproute2 to be able to use them.
Exampes:
ip link set dev br0 type bridge priority 10
ip link set dev br0 type bridge ageing_time 10
ip link set dev br0 type bridge stp_state 1


Best regards,
 Nikolay Aleksandrov

Nikolay Aleksandrov (3):
  iplink_bridge: add support for ageing_time
  iplink_bridge: add support for stp_state
  iplink_bridge: add support for priority

 ip/iplink_bridge.c | 26 ++++++++++++++++++++++++++
 1 file changed, 26 insertions(+)

-- 
2.4.3

[PATCH iproute2 net-next 1/3] iplink_bridge: add support for ageing_time

[Nikolay Aleksandrov]

This patch adds support to set ageing_time via IFLA_BR_AGEING_TIME.

Signed-off-by: Nikolay Aleksandrov <razor@blackwall.org>
---
 ip/iplink_bridge.c | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/ip/iplink_bridge.c b/ip/iplink_bridge.c
index 0cea7d1f5fa2..2726a369803e 100644
--- a/ip/iplink_bridge.c
+++ b/ip/iplink_bridge.c
@@ -23,6 +23,7 @@ static void explain(void)
 		"Usage: ... bridge [ forward_delay FORWARD_DELAY ]\n"
 		"                  [ hello_time HELLO_TIME ]\n"
 		"                  [ max_age MAX_AGE ]\n"
+		"                  [ ageing_time AGEING_TIME ]\n"
 	);
 }
 
@@ -53,6 +54,13 @@ static int bridge_parse_opt(struct link_util *lu, int argc, char **argv,
 				return -1;
 			}
 			addattr32(n, 1024, IFLA_BR_MAX_AGE, val);
+		} else if (matches(*argv, "ageing_time") == 0) {
+			NEXT_ARG();
+			if (get_u32(&val, *argv, 0)) {
+				invarg("invalid ageing_time", *argv);
+				return -1;
+			}
+			addattr32(n, 1024, IFLA_BR_AGEING_TIME, val);
 		} else if (matches(*argv, "help") == 0) {
 			explain();
 			return -1;
-- 
2.4.3

[PATCH iproute2 net-next 2/3] iplink_bridge: add support for stp_state

[Nikolay Aleksandrov]

This patch adds support to set stp_state via IFLA_BR_STP_STATE.

Signed-off-by: Nikolay Aleksandrov <razor@blackwall.org>
---
 ip/iplink_bridge.c | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/ip/iplink_bridge.c b/ip/iplink_bridge.c
index 2726a369803e..79b9e049ff92 100644
--- a/ip/iplink_bridge.c
+++ b/ip/iplink_bridge.c
@@ -24,6 +24,7 @@ static void explain(void)
 		"                  [ hello_time HELLO_TIME ]\n"
 		"                  [ max_age MAX_AGE ]\n"
 		"                  [ ageing_time AGEING_TIME ]\n"
+		"                  [ stp_state STP_STATE ]\n"
 	);
 }
 
@@ -61,6 +62,13 @@ static int bridge_parse_opt(struct link_util *lu, int argc, char **argv,
 				return -1;
 			}
 			addattr32(n, 1024, IFLA_BR_AGEING_TIME, val);
+		} else if (matches(*argv, "stp_state") == 0) {
+			NEXT_ARG();
+			if (get_u32(&val, *argv, 0)) {
+				invarg("invalid stp_state", *argv);
+				return -1;
+			}
+			addattr32(n, 1024, IFLA_BR_STP_STATE, val);
 		} else if (matches(*argv, "help") == 0) {
 			explain();
 			return -1;
-- 
2.4.3

[PATCH iproute2 net-next 3/3] iplink_bridge: add support for priority

[Nikolay Aleksandrov]

This patch adds support to set bridge stp priority via IFLA_BR_PRIORITY.

Signed-off-by: Nikolay Aleksandrov <razor@blackwall.org>
---
 ip/iplink_bridge.c | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/ip/iplink_bridge.c b/ip/iplink_bridge.c
index 79b9e049ff92..297160c490fd 100644
--- a/ip/iplink_bridge.c
+++ b/ip/iplink_bridge.c
@@ -25,6 +25,7 @@ static void explain(void)
 		"                  [ max_age MAX_AGE ]\n"
 		"                  [ ageing_time AGEING_TIME ]\n"
 		"                  [ stp_state STP_STATE ]\n"
+		"                  [ priority PRIORITY ]\n"
 	);
 }
 
@@ -69,6 +70,15 @@ static int bridge_parse_opt(struct link_util *lu, int argc, char **argv,
 				return -1;
 			}
 			addattr32(n, 1024, IFLA_BR_STP_STATE, val);
+		} else if (matches(*argv, "priority") == 0) {
+			__u16 prio;
+
+			NEXT_ARG();
+			if (get_u16(&prio, *argv, 0)) {
+				invarg("invalid priority", *argv);
+				return -1;
+			}
+			addattr16(n, 1024, IFLA_BR_PRIORITY, prio);
 		} else if (matches(*argv, "help") == 0) {
 			explain();
 			return -1;
-- 
2.4.3

Re: [PATCH iproute2 net-next 0/3] iplink_bridge: add support for ageing_time, priority and stp_state

[Stephen Hemminger]

On Tue, 16 Jun 2015 13:38:46 +0300
Nikolay Aleksandrov <razor@blackwall.org> wrote:

> Hi,
> Three months ago support was added to be able to set ageing_time,
> priority and stp_state via netlink by commit:
> af615762e972 ("bridge: add ageing_time, stp_state, priority over netlink")
> This patch-set adds support for iproute2 to be able to use them.
> Exampes:
> ip link set dev br0 type bridge priority 10
> ip link set dev br0 type bridge ageing_time 10
> ip link set dev br0 type bridge stp_state 1
> 
> 
> Best regards,
>  Nikolay Aleksandrov
> 
> Nikolay Aleksandrov (3):
>   iplink_bridge: add support for ageing_time
>   iplink_bridge: add support for stp_state
>   iplink_bridge: add support for priority
> 
>  ip/iplink_bridge.c | 26 ++++++++++++++++++++++++++
>  1 file changed, 26 insertions(+)
> 

All these are staged in net-next branch.