From: Julien Grall <julien.grall@citrix.com>
To: <xen-devel@lists.xenproject.org>
Cc: <linux-kernel@vger.kernel.org>,
Julien Grall <julien.grall@citrix.com>,
David Vrabel <david.vrabel@citrix.com>,
Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
Boris Ostrovsky <boris.ostrovsky@oracle.com>,
<netdev@vger.kernel.org>
Subject: [PATCH v4 1/3] net/xen-netfront: Correct printf format in xennet_get_responses
Date: Tue, 16 Jun 2015 20:10:46 +0100 [thread overview]
Message-ID: <1434481848-26387-2-git-send-email-julien.grall@citrix.com> (raw)
In-Reply-To: <1434481848-26387-1-git-send-email-julien.grall@citrix.com>
rx->status is an int16_t, print it using %d rather than %u in order to
have a meaningful value when the field is negative.
Also use %u rather than %x for rx->offset.
Signed-off-by: Julien Grall <julien.grall@citrix.com>
Reviewed-by: David Vrabel <david.vrabel@citrix.com>
Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Cc: Boris Ostrovsky <boris.ostrovsky@oracle.com>
Cc: netdev@vger.kernel.org
---
Changes in v4:
- Use %u for the rx->offset because offset is unsigned
Changes in v3:
- Use %d for the rx->offset too.
Changes in v2:
- Add David's Reviewed-by
---
drivers/net/xen-netfront.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/xen-netfront.c b/drivers/net/xen-netfront.c
index e031c94..281720f 100644
--- a/drivers/net/xen-netfront.c
+++ b/drivers/net/xen-netfront.c
@@ -733,7 +733,7 @@ static int xennet_get_responses(struct netfront_queue *queue,
if (unlikely(rx->status < 0 ||
rx->offset + rx->status > PAGE_SIZE)) {
if (net_ratelimit())
- dev_warn(dev, "rx->offset: %x, size: %u\n",
+ dev_warn(dev, "rx->offset: %u, size: %d\n",
rx->offset, rx->status);
xennet_move_rx_slot(queue, skb, ref);
err = -EINVAL;
--
2.1.4
next parent reply other threads:[~2015-06-16 19:12 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1434481848-26387-1-git-send-email-julien.grall@citrix.com>
2015-06-16 19:10 ` Julien Grall [this message]
2015-06-21 16:41 ` [PATCH v4 1/3] net/xen-netfront: Correct printf format in xennet_get_responses David Miller
2015-06-16 19:10 ` [PATCH v4 2/3] net/xen-netback: Remove unused code in xenvif_rx_action Julien Grall
2015-06-21 16:41 ` David Miller
2015-06-16 19:10 ` [PATCH v4 3/3] net/xen-netback: Don't mix hexa and decimal with 0x in the printf format Julien Grall
2015-06-16 20:07 ` Sergei Shtylyov
2015-06-16 22:09 ` Joe Perches
2015-06-16 22:29 ` Sergei Shtylyov
2015-06-16 23:55 ` Joe Perches
2015-06-17 8:54 ` Ian Campbell
2015-06-17 9:13 ` [Xen-devel] " Jan Beulich
2015-06-17 9:25 ` Ian Campbell
2015-06-17 9:30 ` Julien Grall
2015-06-17 9:37 ` Ian Campbell
2015-06-21 16:41 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1434481848-26387-2-git-send-email-julien.grall@citrix.com \
--to=julien.grall@citrix.com \
--cc=boris.ostrovsky@oracle.com \
--cc=david.vrabel@citrix.com \
--cc=konrad.wilk@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).