From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
To: davem@davemloft.net
Cc: Jacob Keller <jacob.e.keller@intel.com>,
netdev@vger.kernel.org, nhorman@redhat.com, sassmann@redhat.com,
jogreene@redhat.com, Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Subject: [net-next v2 13/17] fm10k: pack TLV overlay structures
Date: Wed, 17 Jun 2015 05:55:00 -0700 [thread overview]
Message-ID: <1434545704-112470-14-git-send-email-jeffrey.t.kirsher@intel.com> (raw)
In-Reply-To: <1434545704-112470-1-git-send-email-jeffrey.t.kirsher@intel.com>
From: Jacob Keller <jacob.e.keller@intel.com>
This patch adds the __attribute__((packed)) indicator to some structures
which are overlayed onto a TLV message. These structures must be packed
as small as possible in order to correctly align when copied into the
mailbox buffer. Without doing so, the receiving mailbox code incorrectly
parses the values and we get invalid message responses from the switch
manager software.
Signed-off-by: Jacob Keller <jacob.e.keller@intel.com>
Tested-by: Krishneil Singh <Krishneil.k.singh@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
---
drivers/net/ethernet/intel/fm10k/fm10k_pf.h | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/net/ethernet/intel/fm10k/fm10k_pf.h b/drivers/net/ethernet/intel/fm10k/fm10k_pf.h
index 7ab1db4..40a0dbc 100644
--- a/drivers/net/ethernet/intel/fm10k/fm10k_pf.h
+++ b/drivers/net/ethernet/intel/fm10k/fm10k_pf.h
@@ -81,26 +81,26 @@ struct fm10k_mac_update {
__le16 glort;
u8 flags;
u8 action;
-};
+} __packed;
struct fm10k_global_table_data {
__le32 used;
__le32 avail;
-};
+} __packed;
struct fm10k_swapi_error {
__le32 status;
struct fm10k_global_table_data mac;
struct fm10k_global_table_data nexthop;
struct fm10k_global_table_data ffu;
-};
+} __packed;
struct fm10k_swapi_1588_timestamp {
__le64 egress;
__le64 ingress;
__le16 dglort;
__le16 sglort;
-};
+} __packed;
s32 fm10k_msg_lport_map_pf(struct fm10k_hw *, u32 **, struct fm10k_mbx_info *);
extern const struct fm10k_tlv_attr fm10k_lport_map_msg_attr[];
--
2.4.3
next prev parent reply other threads:[~2015-06-17 12:55 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-17 12:54 [net-next v2 00/17][pull request] Intel Wired LAN Driver Updates 2015-06-17 Jeff Kirsher
2015-06-17 12:54 ` [net-next v2 01/17] fm10k: fold fm10k_pull_tail into fm10k_add_rx_frag Jeff Kirsher
2015-06-17 12:54 ` [net-next v2 02/17] fm10k: ignore invalid multicast address entries Jeff Kirsher
2015-06-17 12:54 ` [net-next v2 03/17] fm10k: use correct ethernet driver Tx timestamp function Jeff Kirsher
2015-06-17 12:54 ` [net-next v2 04/17] fm10k: move setting shinfo inside ts_tx_enqueue Jeff Kirsher
2015-06-17 12:54 ` [net-next v2 05/17] fm10k: fix incorrect free on skb in ts_tx_enqueue Jeff Kirsher
2015-06-17 12:54 ` [net-next v2 06/17] fm10k: add call to fm10k_clean_all_rx_rings in fm10k_down Jeff Kirsher
2015-06-17 12:54 ` [net-next v2 07/17] fm10k: use an unsigned int for i in ethtool_get_strings Jeff Kirsher
2015-06-17 12:54 ` [net-next v2 08/17] fm10k: remove extraneous NULL check on l2_accel Jeff Kirsher
2015-06-17 12:54 ` [net-next v2 09/17] fm10k: trivial fixup message style to include a colon Jeff Kirsher
2015-06-17 12:54 ` [net-next v2 10/17] fm10k: use dma_set_mask_and_coherent in fm10k_probe Jeff Kirsher
2015-06-17 12:54 ` [net-next v2 11/17] fm10k: force LPORT delete when updating VLAN or MAC address Jeff Kirsher
2015-06-17 12:54 ` [net-next v2 12/17] fm10k: re-map all possible VF queues after a VFLR Jeff Kirsher
2015-06-17 12:55 ` Jeff Kirsher [this message]
2015-06-17 12:55 ` [net-next v2 14/17] fm10k: fix incorrect DIR_NEVATIVE bit in 1588 code Jeff Kirsher
2015-06-17 12:55 ` [net-next v2 15/17] fm10k: remove err_no reference in fm10k_mbx.c Jeff Kirsher
2015-06-17 12:55 ` [net-next v2 16/17] fm10k: fix iov_msg_lport_state_pf issue Jeff Kirsher
2015-06-17 12:55 ` [net-next v2 17/17] fm10k: Fix missing braces after if statement Jeff Kirsher
2015-06-18 10:59 ` [net-next v2 00/17][pull request] Intel Wired LAN Driver Updates 2015-06-17 David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1434545704-112470-14-git-send-email-jeffrey.t.kirsher@intel.com \
--to=jeffrey.t.kirsher@intel.com \
--cc=davem@davemloft.net \
--cc=jacob.e.keller@intel.com \
--cc=jogreene@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=nhorman@redhat.com \
--cc=sassmann@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).