netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Paul Bolle <pebolle@tiscali.nl>
To: igal.liberman@freescale.com, netdev@vger.kernel.org
Cc: linuxppc-dev@lists.ozlabs.org, scottwood@freescale.com,
	madalin.bucur@freescale.com
Subject: Re: [v2,9/9] fsl/fman: Add FMan MAC driver
Date: Fri, 26 Jun 2015 01:06:30 +0200	[thread overview]
Message-ID: <1435273590.28572.11.camel@tiscali.nl> (raw)
In-Reply-To: <1435174672-4608-1-git-send-email-igal.liberman@freescale.com>

(Evolution 3.16 is basically unbearable for replying to patches. Anyone
else running into this?) 

On Wed, 2015-06-24 at 22:37 +0300, igal.liberman@freescale.com wrote:
> 
> --- /dev/null
> +++ b/drivers/net/ethernet/freescale/fman/mac/mac-api.c
> +int set_mac_active_pause(struct mac_device *mac_dev, bool rx, bool tx)
> +{
> +	[...]
> +}
> +EXPORT_SYMBOL(set_mac_active_pause);

Which module is using this function?

> +void get_pause_cfg(struct mac_device *mac_dev, bool *rx_pause, bool *tx_pause)
> +{
> +	[...]
> +}
> +EXPORT_SYMBOL(get_pause_cfg);

This exports a function that is only used in this file. Why? 

Thanks,


Paul Bolle

  reply	other threads:[~2015-06-25 23:06 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-24 19:37 [v2,9/9] fsl/fman: Add FMan MAC driver igal.liberman
2015-06-25 23:06 ` Paul Bolle [this message]
2015-06-26  0:59   ` Scott Wood
2015-06-26  2:21     ` Michael Ellerman
2015-06-26  2:25       ` Scott Wood
2015-06-29  1:55         ` Michael Ellerman
2015-06-26  7:01     ` Paul Bolle

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1435273590.28572.11.camel@tiscali.nl \
    --to=pebolle@tiscali.nl \
    --cc=igal.liberman@freescale.com \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=madalin.bucur@freescale.com \
    --cc=netdev@vger.kernel.org \
    --cc=scottwood@freescale.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).