From: Jan Blunck <jblunck@infradead.org>
To: linux-kernel@vger.kernel.org
Cc: jiri@resnulli.us, netdev@vger.kernel.org
Subject: [PATCH] team: set IFF_SLAVE on team ports
Date: Thu, 9 Jul 2015 11:58:34 +0200 [thread overview]
Message-ID: <1436435914-8903-1-git-send-email-jblunck@infradead.org> (raw)
The code in net/ipv6/addrconf.c:addrconf_notify() tests for IFF_SLAVE to
decide if it should start the address configuration. Since team ports
shouldn't get link-local addresses assigned lets set IFF_SLAVE when linking
a port to the team master.
Signed-off-by: Jan Blunck <jblunck@infradead.org>
---
drivers/net/team/team.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/net/team/team.c b/drivers/net/team/team.c
index daa054b..4cd02c8 100644
--- a/drivers/net/team/team.c
+++ b/drivers/net/team/team.c
@@ -1086,6 +1086,7 @@ static int team_upper_dev_link(struct net_device *dev,
err = netdev_master_upper_dev_link(port_dev, dev);
if (err)
return err;
+ port_dev->flags |= IFF_SLAVE;
port_dev->priv_flags |= IFF_TEAM_PORT;
return 0;
}
@@ -1094,6 +1095,7 @@ static void team_upper_dev_unlink(struct net_device *dev,
struct net_device *port_dev)
{
netdev_upper_dev_unlink(port_dev, dev);
+ port_dev->flags &= ~IFF_SLAVE;
port_dev->priv_flags &= ~IFF_TEAM_PORT;
}
--
2.1.4
next reply other threads:[~2015-07-09 9:58 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-09 9:58 Jan Blunck [this message]
2015-07-09 10:07 ` [PATCH] team: set IFF_SLAVE on team ports Jiri Pirko
2015-07-09 15:36 ` Jan Blunck
2015-07-10 6:41 ` Jiri Pirko
2018-09-27 14:04 ` Chas Williams
2018-09-30 7:14 ` Jiri Pirko
2018-09-30 9:38 ` Stephen Hemminger
2018-09-30 9:34 ` Jiri Pirko
2018-10-01 14:06 ` Chas Williams
2018-10-02 11:12 ` Jiri Pirko
2018-10-02 21:20 ` Chas Williams
2018-10-03 10:44 ` Jiri Pirko
2018-10-03 17:30 ` Chas Williams
2018-10-05 6:46 ` Jiri Pirko
2018-10-06 13:28 ` Chas Williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1436435914-8903-1-git-send-email-jblunck@infradead.org \
--to=jblunck@infradead.org \
--cc=jiri@resnulli.us \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).