From: Sathya Perla <sathya.perla@avagotech.com>
To: netdev@vger.kernel.org
Subject: [PATCH net-next 4/9] be2net: fix wrong return value in be_check_ufi_compatibility()
Date: Fri, 10 Jul 2015 05:32:46 -0400 [thread overview]
Message-ID: <1436520771-11656-5-git-send-email-sathya.perla@avagotech.com> (raw)
In-Reply-To: <1436520771-11656-1-git-send-email-sathya.perla@avagotech.com>
From: Vasundhara Volam <vasundhara.volam@avagotech.com>
In the commit a6e6ff6eee12f3e
("be2net: simplify UFI compatibility checking"), a return value of "-1"
was incorrectly used in place of "false". This patch fixes it.
Fixes: a6e6ff6eee12f3e ("be2net: simplify UFI compatibility checking")
Signed-off-by: Vasundhara Volam <vasundhara.volam@avagotech.com>
Signed-off-by: Sathya Perla <sathya.perla@avagotech.com>
---
drivers/net/ethernet/emulex/benet/be_main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/emulex/benet/be_main.c b/drivers/net/ethernet/emulex/benet/be_main.c
index 8b81e23..8ef7ea5 100644
--- a/drivers/net/ethernet/emulex/benet/be_main.c
+++ b/drivers/net/ethernet/emulex/benet/be_main.c
@@ -4918,7 +4918,7 @@ static bool be_check_ufi_compatibility(struct be_adapter *adapter,
{
if (!fhdr) {
dev_err(&adapter->pdev->dev, "Invalid FW UFI file");
- return -1;
+ return false;
}
/* First letter of the build version is used to identify
--
2.4.1
next prev parent reply other threads:[~2015-07-10 9:26 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-10 9:32 [PATCH net-next 0/9] be2net: patch set Sathya Perla
2015-07-10 9:32 ` [PATCH net-next 1/9] be2net: remove duplicate code in be_setup_wol() Sathya Perla
2015-07-10 9:32 ` [PATCH net-next 2/9] be2net: query FW to check if EVB is enabled Sathya Perla
2015-07-10 9:32 ` [PATCH net-next 3/9] be2net: remove redundant D0 power state set Sathya Perla
2015-07-10 9:32 ` Sathya Perla [this message]
2015-07-10 9:32 ` [PATCH net-next 5/9] be2net: convert dest field in udp-hdr to host-endian Sathya Perla
2015-07-10 9:32 ` [PATCH net-next 6/9] be2net: return error status from be_mcc_notify() Sathya Perla
2015-07-10 9:32 ` [PATCH net-next 7/9] be2net: make the RX_FILTER command asynchronous Sathya Perla
2015-07-10 9:32 ` [PATCH net-next 8/9] be2net: make SET_LOOPBACK_MODE cmd asynchrounous Sathya Perla
2015-07-10 9:32 ` [PATCH net-next 9/9] be2net: bump up the driver version to 10.6.0.3 Sathya Perla
2015-07-11 6:24 ` [PATCH net-next 0/9] be2net: patch set David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1436520771-11656-5-git-send-email-sathya.perla@avagotech.com \
--to=sathya.perla@avagotech.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).