netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
To: davem@davemloft.net
Cc: Mitch Williams <mitch.a.williams@intel.com>,
	netdev@vger.kernel.org, nhorman@redhat.com, sassmann@redhat.com,
	jogreene@redhat.com, Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Subject: [net-next 06/16] i40e: ignore duplicate port VLAN requests
Date: Mon, 13 Jul 2015 02:08:27 -0700	[thread overview]
Message-ID: <1436778517-16254-7-git-send-email-jeffrey.t.kirsher@intel.com> (raw)
In-Reply-To: <1436778517-16254-1-git-send-email-jeffrey.t.kirsher@intel.com>

From: Mitch Williams <mitch.a.williams@intel.com>

If user attempts to set a port VLAN on a VF that already has the same
port VLAN configured, the driver will go through a completely
unnecessary flurry of filter removals and filter adds. Just check for
this condition and return success instead of doing a bunch of busywork.

Change-ID: Ia1a9e83e6ed48b3f4658bc20dfc6af0cf525d54a
Signed-off-by: Mitch Williams <mitch.a.williams@intel.com>
Tested-by: Jim Young <james.m.young@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
---
 drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c b/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c
index 23f95cd..433e803 100644
--- a/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c
+++ b/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c
@@ -2088,6 +2088,10 @@ int i40e_ndo_set_vf_port_vlan(struct net_device *netdev,
 		goto error_pvid;
 	}
 
+	if (vsi->info.pvid == (vlan_id | (qos << I40E_VLAN_PRIORITY_SHIFT)))
+		/* duplicate request, so just return success */
+		goto error_pvid;
+
 	if (vsi->info.pvid == 0 && i40e_is_vsi_in_vlan(vsi)) {
 		dev_err(&pf->pdev->dev,
 			"VF %d has already configured VLAN filters and the administrator is requesting a port VLAN override.\nPlease unload and reload the VF driver for this change to take effect.\n",
-- 
2.4.3

  parent reply	other threads:[~2015-07-13  9:08 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-13  9:08 [net-next 00/16][pull request] Intel Wired LAN Driver Updates 2015-07-13 Jeff Kirsher
2015-07-13  9:08 ` [net-next 01/16] i40e: Implement ndo_features_check() Jeff Kirsher
2015-07-13  9:08 ` [net-next 02/16] i40e/i40evf: Add stats to track FD ATR and SB dynamic enable state Jeff Kirsher
2015-07-13  9:08 ` [net-next 03/16] i40e/i40evf: Update Flex-10 related device/function capabilities Jeff Kirsher
2015-07-13  9:08 ` [net-next 04/16] i40e/i40evf: improve Tx performance with a small tweak Jeff Kirsher
2015-07-13  9:08 ` [net-next 05/16] i40evf: Allow for an abundance of vectors Jeff Kirsher
2015-07-13  9:08 ` Jeff Kirsher [this message]
2015-07-13  9:08 ` [net-next 07/16] i40e: Remove incorrect #ifdef's Jeff Kirsher
2015-07-13  9:08 ` [net-next 08/16] i40e/i40evf: Update the admin queue command header Jeff Kirsher
2015-07-13  9:08 ` [net-next 09/16] i40e: correctly program filters for VFs Jeff Kirsher
2015-07-13  9:08 ` [net-next 10/16] i40e: do a proper reset when disabling a VF Jeff Kirsher
2015-07-13  9:08 ` [net-next 11/16] i40e: un-disable VF after reset Jeff Kirsher
2015-07-13  9:08 ` [net-next 12/16] i40evf: don't delete all the filters Jeff Kirsher
2015-07-13 12:51   ` Sergei Shtylyov
2015-07-13  9:08 ` [net-next 13/16] i40evf: add MAC address filter in open, not init Jeff Kirsher
2015-07-13  9:08 ` [net-next 14/16] i40e/i40evf: Add support for pre-allocated pages for PD Jeff Kirsher
2015-07-13  9:08 ` [net-next 15/16] i40e: Refine an error message to avoid confusion Jeff Kirsher
2015-07-13  9:08 ` [net-next 16/16] i40e/i40evf: Bump version to 1.3.6 for i40e and 1.3.2 for i40evf Jeff Kirsher

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1436778517-16254-7-git-send-email-jeffrey.t.kirsher@intel.com \
    --to=jeffrey.t.kirsher@intel.com \
    --cc=davem@davemloft.net \
    --cc=jogreene@redhat.com \
    --cc=mitch.a.williams@intel.com \
    --cc=netdev@vger.kernel.org \
    --cc=nhorman@redhat.com \
    --cc=sassmann@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).