* [V2 1/7] Drivers: hv: vmbus: define the new offer type for Hyper-V socket (hvsock)
@ 2015-07-14 9:58 Dexuan Cui
2015-07-16 4:13 ` David Miller
0 siblings, 1 reply; 3+ messages in thread
From: Dexuan Cui @ 2015-07-14 9:58 UTC (permalink / raw)
To: gregkh, davem, stephen, netdev, linux-kernel, driverdev-devel,
olaf, apw, jasowang, kys
A helper function is also added.
Signed-off-by: Dexuan Cui <decui@microsoft.com>
---
include/linux/hyperv.h | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/include/linux/hyperv.h b/include/linux/hyperv.h
index 30d3a1f..aa21814 100644
--- a/include/linux/hyperv.h
+++ b/include/linux/hyperv.h
@@ -236,6 +236,7 @@ struct vmbus_channel_offer {
#define VMBUS_CHANNEL_LOOPBACK_OFFER 0x100
#define VMBUS_CHANNEL_PARENT_OFFER 0x200
#define VMBUS_CHANNEL_REQUEST_MONITORED_NOTIFICATION 0x400
+#define VMBUS_CHANNEL_TLNPI_PROVIDER_OFFER 0x2000
struct vmpacket_descriptor {
u16 type;
@@ -758,6 +759,12 @@ struct vmbus_channel {
struct list_head percpu_list;
};
+static inline bool is_hvsock_channel(const struct vmbus_channel *c)
+{
+ return !!(c->offermsg.offer.chn_flags &
+ VMBUS_CHANNEL_TLNPI_PROVIDER_OFFER);
+}
+
static inline void set_channel_read_state(struct vmbus_channel *c, bool state)
{
c->batched_reading = state;
--
2.1.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [V2 1/7] Drivers: hv: vmbus: define the new offer type for Hyper-V socket (hvsock)
2015-07-14 9:58 [V2 1/7] Drivers: hv: vmbus: define the new offer type for Hyper-V socket (hvsock) Dexuan Cui
@ 2015-07-16 4:13 ` David Miller
2015-07-16 11:18 ` Dexuan Cui
0 siblings, 1 reply; 3+ messages in thread
From: David Miller @ 2015-07-16 4:13 UTC (permalink / raw)
To: decui
Cc: gregkh, stephen, netdev, linux-kernel, driverdev-devel, olaf, apw,
jasowang, kys
From: Dexuan Cui <decui@microsoft.com>
Date: Tue, 14 Jul 2015 02:58:03 -0700
> A helper function is also added.
>
> Signed-off-by: Dexuan Cui <decui@microsoft.com>
> ---
> include/linux/hyperv.h | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/include/linux/hyperv.h b/include/linux/hyperv.h
> index 30d3a1f..aa21814 100644
> --- a/include/linux/hyperv.h
> +++ b/include/linux/hyperv.h
> @@ -236,6 +236,7 @@ struct vmbus_channel_offer {
> #define VMBUS_CHANNEL_LOOPBACK_OFFER 0x100
> #define VMBUS_CHANNEL_PARENT_OFFER 0x200
> #define VMBUS_CHANNEL_REQUEST_MONITORED_NOTIFICATION 0x400
> +#define VMBUS_CHANNEL_TLNPI_PROVIDER_OFFER 0x2000
>
> struct vmpacket_descriptor {
> u16 type;
> @@ -758,6 +759,12 @@ struct vmbus_channel {
> struct list_head percpu_list;
> };
>
> +static inline bool is_hvsock_channel(const struct vmbus_channel *c)
> +{
> + return !!(c->offermsg.offer.chn_flags &
> + VMBUS_CHANNEL_TLNPI_PROVIDER_OFFER);
> +}
> +
This is not indented properly, plus it makes no sense to add a flag before
anyone even sets the flag.
^ permalink raw reply [flat|nested] 3+ messages in thread
* RE: [V2 1/7] Drivers: hv: vmbus: define the new offer type for Hyper-V socket (hvsock)
2015-07-16 4:13 ` David Miller
@ 2015-07-16 11:18 ` Dexuan Cui
0 siblings, 0 replies; 3+ messages in thread
From: Dexuan Cui @ 2015-07-16 11:18 UTC (permalink / raw)
To: David Miller
Cc: gregkh@linuxfoundation.org, stephen@networkplumber.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
driverdev-devel@linuxdriverproject.org, olaf@aepfle.de,
apw@canonical.com, jasowang@redhat.com, KY Srinivasan
> From: David Miller
> Sent: Thursday, July 16, 2015 12:13
>
> From: Dexuan Cui
> Date: Tue, 14 Jul 2015 02:58:03 -0700
>
> > A helper function is also added.
> >
> > diff --git a/include/linux/hyperv.h b/include/linux/hyperv.h
> > @@ -236,6 +236,7 @@ struct vmbus_channel_offer {
> > #define VMBUS_CHANNEL_LOOPBACK_OFFER 0x100
> > #define VMBUS_CHANNEL_PARENT_OFFER 0x200
> > #define VMBUS_CHANNEL_REQUEST_MONITORED_NOTIFICATION 0x400
> > +#define VMBUS_CHANNEL_TLNPI_PROVIDER_OFFER 0x2000
> >
> > struct vmpacket_descriptor {
> > u16 type;
> > @@ -758,6 +759,12 @@ struct vmbus_channel {
> > struct list_head percpu_list;
> > };
> >
> > +static inline bool is_hvsock_channel(const struct vmbus_channel *c)
> > +{
> > + return !!(c->offermsg.offer.chn_flags &
> > + VMBUS_CHANNEL_TLNPI_PROVIDER_OFFER);
> > +}
> > +
>
> This is not indented properly, plus it makes no sense to add a flag before
> anyone even sets the flag.
Hi David,
Thanks for pointing out the indentation issue! I'll fix it in V3.
The flag is set by the host: the c->offermsg is in the shared VMBus ringbuffer
between the host and the guest, so it makes sense for us to check the flag. :-)
-- Dexuan
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-07-16 11:18 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-07-14 9:58 [V2 1/7] Drivers: hv: vmbus: define the new offer type for Hyper-V socket (hvsock) Dexuan Cui
2015-07-16 4:13 ` David Miller
2015-07-16 11:18 ` Dexuan Cui
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).