* [PATCH net] tc: act_bpf: fix memory leak
@ 2015-07-14 19:15 Alexei Starovoitov
2015-07-16 4:37 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Alexei Starovoitov @ 2015-07-14 19:15 UTC (permalink / raw)
To: David S. Miller; +Cc: Daniel Borkmann, Jiri Pirko, netdev
prog->bpf_ops is populated when act_bpf is used with classic BPF and
prog->bpf_name is optionally used with extended BPF.
Fix memory leak when act_bpf is released.
Fixes: d23b8ad8ab23 ("tc: add BPF based action")
Fixes: a8cb5f556b56 ("act_bpf: add initial eBPF support for actions")
Acked-by: Daniel Borkmann <daniel@iogearbox.net>
Signed-off-by: Alexei Starovoitov <ast@plumgrid.com>
---
net/sched/act_bpf.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/net/sched/act_bpf.c b/net/sched/act_bpf.c
index 1d56903fd4c7..1df78289e248 100644
--- a/net/sched/act_bpf.c
+++ b/net/sched/act_bpf.c
@@ -339,6 +339,9 @@ static void tcf_bpf_cleanup(struct tc_action *act, int bind)
bpf_prog_put(prog->filter);
else
bpf_prog_destroy(prog->filter);
+
+ kfree(prog->bpf_ops);
+ kfree(prog->bpf_name);
}
static struct tc_action_ops act_bpf_ops __read_mostly = {
--
1.7.9.5
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH net] tc: act_bpf: fix memory leak
2015-07-14 19:15 [PATCH net] tc: act_bpf: fix memory leak Alexei Starovoitov
@ 2015-07-16 4:37 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2015-07-16 4:37 UTC (permalink / raw)
To: ast; +Cc: daniel, jiri, netdev
From: Alexei Starovoitov <ast@plumgrid.com>
Date: Tue, 14 Jul 2015 12:15:19 -0700
> prog->bpf_ops is populated when act_bpf is used with classic BPF and
> prog->bpf_name is optionally used with extended BPF.
> Fix memory leak when act_bpf is released.
>
> Fixes: d23b8ad8ab23 ("tc: add BPF based action")
> Fixes: a8cb5f556b56 ("act_bpf: add initial eBPF support for actions")
> Acked-by: Daniel Borkmann <daniel@iogearbox.net>
> Signed-off-by: Alexei Starovoitov <ast@plumgrid.com>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-07-16 4:37 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-07-14 19:15 [PATCH net] tc: act_bpf: fix memory leak Alexei Starovoitov
2015-07-16 4:37 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).