From: Bastien Nocera <hadess@hadess.net>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Johannes Berg <johannes@sipsolutions.net>,
"David S. Miller" <davem@davemloft.net>
Cc: linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] rfkill-gpio: Add support for the Realtek 8723 BT
Date: Wed, 15 Jul 2015 08:30:30 +0200 [thread overview]
Message-ID: <1436941830.20249.64.camel@hadess.net> (raw)
In-Reply-To: <55A50C82.4040107@lwfinger.net>
On Tue, 2015-07-14 at 08:20 -0500, Larry Finger wrote:
> On 07/13/2015 05:11 PM, Bastien Nocera wrote:
> > http://thread.gmane.org/gmane.linux.kernel.wireless.general/127706/
> > focu
> > s=127896
> >
> > Signed-off-by: Bastien Nocera <hadess@hadess.net>
>
> Bastien,
>
> The subject of this patch needs a bit more detail. I know that you
> mean the
> RTL8723B versions of the Bluetooth devices. The subject should say
> this.
>
> The commit message needs a bit more detail. Referencing the E-mail
> thread is OK,
> but a bit more is needed. What fails without this change?
Nothing yet, as the current Bluetooth support for this device is
completely in user-space, and doesn't sync up with rfkill.
> To help keep that patches straight, change the next submission to say
> "[PATCH
> V2]" in the subject. In addition, after the ---, add a section saying
> what
> changed in V2. That info is not retained in the final commit message
> in the
> repo, but it can be very useful to a maintainer.
I already submitted this patch? I certainly forgot doing so :)
next prev parent reply other threads:[~2015-07-15 6:30 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-13 22:11 [PATCH] rfkill-gpio: Add support for the Realtek 8723 BT Bastien Nocera
2015-07-14 13:20 ` Larry Finger
2015-07-14 13:21 ` Johannes Berg
2015-07-15 6:32 ` Bastien Nocera
2015-07-20 5:34 ` Kalle Valo
2015-07-15 6:30 ` Bastien Nocera [this message]
2015-07-14 15:29 ` Marcel Holtmann
2015-07-15 6:27 ` Bastien Nocera
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1436941830.20249.64.camel@hadess.net \
--to=hadess@hadess.net \
--cc=Larry.Finger@lwfinger.net \
--cc=davem@davemloft.net \
--cc=johannes@sipsolutions.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).