From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
To: Michael Ellerman <mpe@ellerman.id.au>,
"Avargil, Raanan" <raanan.avargil@intel.com>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
intel-wired-lan@lists.osuosl.org, aaron.f.brown@intel.com,
yanirx.lubetkin@intel.com, jesse.brandeburg@intel.com,
shannon.nelson@intel.com, carolyn.wyborny@intel.com,
donald.c.skidmore@intel.com, matthew.vick@intel.com,
john.ronciak@intel.com, mitch.a.williams@intel.com
Subject: Re: [PATCH] e1000e: Move e1000e_disable_aspm_locked() inside CONFIG_PM
Date: Wed, 15 Jul 2015 03:30:16 -0700 [thread overview]
Message-ID: <1436956216.13597.8.camel@intel.com> (raw)
In-Reply-To: <1436846075-29366-1-git-send-email-mpe@ellerman.id.au>
[-- Attachment #1: Type: text/plain, Size: 720 bytes --]
On Tue, 2015-07-14 at 13:54 +1000, Michael Ellerman wrote:
> e1000e_disable_aspm_locked() is only used in __e1000_resume() which is
> inside CONFIG_PM. So when CONFIG_PM=n we get a "defined but not used"
> warning for e1000e_disable_aspm_locked().
>
> Move it inside the existing CONFIG_PM block to avoid the warning.
>
> Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
> ---
> drivers/net/ethernet/intel/e1000e/netdev.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
NACK, this is already fixed in my next-queue tree. Raanan submitted a
patch back on July 6th to resolve this issue, see commit id
a75787d2246a93d256061db602f252703559af65 in my dev-queue branch of my
next-queue tree.
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2015-07-15 10:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-14 3:54 [PATCH] e1000e: Move e1000e_disable_aspm_locked() inside CONFIG_PM Michael Ellerman
2015-07-15 10:30 ` Jeff Kirsher [this message]
2015-07-22 1:41 ` Michael Ellerman
2015-07-23 14:07 ` Jeff Kirsher
2015-07-25 9:12 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1436956216.13597.8.camel@intel.com \
--to=jeffrey.t.kirsher@intel.com \
--cc=aaron.f.brown@intel.com \
--cc=carolyn.wyborny@intel.com \
--cc=donald.c.skidmore@intel.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jesse.brandeburg@intel.com \
--cc=john.ronciak@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=matthew.vick@intel.com \
--cc=mitch.a.williams@intel.com \
--cc=mpe@ellerman.id.au \
--cc=netdev@vger.kernel.org \
--cc=raanan.avargil@intel.com \
--cc=shannon.nelson@intel.com \
--cc=yanirx.lubetkin@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).