netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
To: davem@davemloft.net
Cc: Fan Du <fan.du@intel.com>,
	netdev@vger.kernel.org, nhorman@redhat.com, sassmann@redhat.com,
	jogreene@redhat.com, Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Subject: [net-next 13/14] ixgbe: Don't report flow director filter's status
Date: Fri, 17 Jul 2015 07:25:22 -0700	[thread overview]
Message-ID: <1437143123-5031-14-git-send-email-jeffrey.t.kirsher@intel.com> (raw)
In-Reply-To: <1437143123-5031-1-git-send-email-jeffrey.t.kirsher@intel.com>

From: Fan Du <fan.du@intel.com>

For two reasons I want to disable this:
1. Not any part actually check the report status(Alexander Duyck)
2. To report hash value of a packet to stack,
   RSS -> 32bits hash value
   Perfect match fdir filter -> 13bits hash value
   Hashed-based fdir filter -> 31bits hash value

   fdir filter might hash on masked tuples for IP address,
   so it's still not desirable for usage.

So for now, just stick to RSS 32bits hash value.

Signed-off-by: Fan Du <fan.du@intel.com>
Suggested-by: Alexander Duyck <alexander.h.duyck@redhat.com>
Tested-by: Phil Schmitt <phillip.j.schmitt@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
---
 drivers/net/ethernet/intel/ixgbe/ixgbe_82599.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_82599.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_82599.c
index 6b87d96..b1e364d 100644
--- a/drivers/net/ethernet/intel/ixgbe/ixgbe_82599.c
+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_82599.c
@@ -1394,14 +1394,12 @@ s32 ixgbe_init_fdir_perfect_82599(struct ixgbe_hw *hw, u32 fdirctrl)
 	/*
 	 * Continue setup of fdirctrl register bits:
 	 *  Turn perfect match filtering on
-	 *  Report hash in RSS field of Rx wb descriptor
 	 *  Initialize the drop queue
 	 *  Move the flexible bytes to use the ethertype - shift 6 words
 	 *  Set the maximum length per hash bucket to 0xA filters
 	 *  Send interrupt when 64 (0x4 * 16) filters are left
 	 */
 	fdirctrl |= IXGBE_FDIRCTRL_PERFECT_MATCH |
-		    IXGBE_FDIRCTRL_REPORT_STATUS |
 		    (IXGBE_FDIR_DROP_QUEUE << IXGBE_FDIRCTRL_DROP_Q_SHIFT) |
 		    (0x6 << IXGBE_FDIRCTRL_FLEX_SHIFT) |
 		    (0xA << IXGBE_FDIRCTRL_MAX_LENGTH_SHIFT) |
-- 
2.4.3

  parent reply	other threads:[~2015-07-17 14:25 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-17 14:25 [net-next 00/14][pull request] Intel Wired LAN Driver Updates 2015-07-17 Jeff Kirsher
2015-07-17 14:25 ` [net-next 01/14] clarify implementation of ethtool's get_ts_info op Jeff Kirsher
2015-07-17 19:17   ` Richard Cochran
2015-07-17 14:25 ` [net-next 02/14] freescale: remove incorrect copied comment Jeff Kirsher
2015-07-17 14:25 ` [net-next 03/14] bnx2x: only report most generic filters in get_ts_info Jeff Kirsher
2015-07-17 14:25 ` [net-next 04/14] i40e: only report " Jeff Kirsher
2015-07-17 14:25 ` [net-next 05/14] igb: " Jeff Kirsher
2015-07-17 14:25 ` [net-next 06/14] ixgbe: " Jeff Kirsher
2015-07-17 14:25 ` [net-next 07/14] siena: " Jeff Kirsher
2015-07-17 14:25 ` [net-next 08/14] dp83640: only report generic filters in ts_info Jeff Kirsher
2015-07-17 14:25 ` [net-next 09/14] igb: Pull timestamp from fragment before adding it to skb Jeff Kirsher
2015-07-17 14:25 ` [net-next 10/14] ixgbevf: fold ixgbevf_pull_tail into ixgbevf_add_rx_frag Jeff Kirsher
2015-07-17 14:25 ` [net-next 11/14] ixgbe: Specify Rx hash type WRT Rx desc RSS type Jeff Kirsher
2015-07-17 14:25 ` [net-next 12/14] ixgbevf: Set Rx hash type for ingress packets Jeff Kirsher
2015-07-17 14:25 ` Jeff Kirsher [this message]
2015-07-17 14:25 ` [net-next 14/14] igb: Fix i354 88E1112 PHY on RCC boards using AutoMediaDetect Jeff Kirsher
2015-07-21  3:50 ` [net-next 00/14][pull request] Intel Wired LAN Driver Updates 2015-07-17 David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1437143123-5031-14-git-send-email-jeffrey.t.kirsher@intel.com \
    --to=jeffrey.t.kirsher@intel.com \
    --cc=davem@davemloft.net \
    --cc=fan.du@intel.com \
    --cc=jogreene@redhat.com \
    --cc=netdev@vger.kernel.org \
    --cc=nhorman@redhat.com \
    --cc=sassmann@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).