* [PATCH net-next v2] bridge: Fix setting a flag in br_fill_ifvlaninfo_range().
@ 2015-07-22 4:57 Rami Rosen
2015-07-22 5:52 ` roopa
2015-07-25 5:57 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Rami Rosen @ 2015-07-22 4:57 UTC (permalink / raw)
To: davem; +Cc: netdev, roopa, stephen, Rami Rosen
This patch fixes setting of vinfo.flags in the br_fill_ifvlaninfo_range() method. The
assignment of vinfo.flags &= ~BRIDGE_VLAN_INFO_RANGE_BEGIN has no effect and is
unneeded, as vinfo.flags value is overriden by the immediately following
vinfo.flags = flags | BRIDGE_VLAN_INFO_RANGE_END assignement.
Signed-off-by: Rami Rosen <rami.rosen@intel.com>
---
net/bridge/br_netlink.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/net/bridge/br_netlink.c b/net/bridge/br_netlink.c
index 364bdc9..793d247 100644
--- a/net/bridge/br_netlink.c
+++ b/net/bridge/br_netlink.c
@@ -164,8 +164,6 @@ static int br_fill_ifvlaninfo_range(struct sk_buff *skb, u16 vid_start,
sizeof(vinfo), &vinfo))
goto nla_put_failure;
- vinfo.flags &= ~BRIDGE_VLAN_INFO_RANGE_BEGIN;
-
vinfo.vid = vid_end;
vinfo.flags = flags | BRIDGE_VLAN_INFO_RANGE_END;
if (nla_put(skb, IFLA_BRIDGE_VLAN_INFO,
--
1.9.3
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH net-next v2] bridge: Fix setting a flag in br_fill_ifvlaninfo_range().
2015-07-22 4:57 [PATCH net-next v2] bridge: Fix setting a flag in br_fill_ifvlaninfo_range() Rami Rosen
@ 2015-07-22 5:52 ` roopa
2015-07-25 5:57 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: roopa @ 2015-07-22 5:52 UTC (permalink / raw)
To: Rami Rosen; +Cc: davem, netdev, stephen
On 7/21/15, 9:57 PM, Rami Rosen wrote:
> This patch fixes setting of vinfo.flags in the br_fill_ifvlaninfo_range() method. The
> assignment of vinfo.flags &= ~BRIDGE_VLAN_INFO_RANGE_BEGIN has no effect and is
> unneeded, as vinfo.flags value is overriden by the immediately following
> vinfo.flags = flags | BRIDGE_VLAN_INFO_RANGE_END assignement.
>
> Signed-off-by: Rami Rosen <rami.rosen@intel.com>
>
Acked-by: Roopa Prabhu <roopa@cumulusnetworks.com>
Thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net-next v2] bridge: Fix setting a flag in br_fill_ifvlaninfo_range().
2015-07-22 4:57 [PATCH net-next v2] bridge: Fix setting a flag in br_fill_ifvlaninfo_range() Rami Rosen
2015-07-22 5:52 ` roopa
@ 2015-07-25 5:57 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2015-07-25 5:57 UTC (permalink / raw)
To: rami.rosen; +Cc: netdev, roopa, stephen
From: Rami Rosen <rami.rosen@intel.com>
Date: Wed, 22 Jul 2015 07:57:02 +0300
> This patch fixes setting of vinfo.flags in the br_fill_ifvlaninfo_range() method. The
> assignment of vinfo.flags &= ~BRIDGE_VLAN_INFO_RANGE_BEGIN has no effect and is
> unneeded, as vinfo.flags value is overriden by the immediately following
> vinfo.flags = flags | BRIDGE_VLAN_INFO_RANGE_END assignement.
>
> Signed-off-by: Rami Rosen <rami.rosen@intel.com>
Applied.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-07-25 5:44 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-07-22 4:57 [PATCH net-next v2] bridge: Fix setting a flag in br_fill_ifvlaninfo_range() Rami Rosen
2015-07-22 5:52 ` roopa
2015-07-25 5:57 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).