* [PATCH net-next] ipv4: be more aggressive when probing alternative gateways
@ 2015-07-23 7:39 Julian Anastasov
2015-07-27 3:57 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Julian Anastasov @ 2015-07-23 7:39 UTC (permalink / raw)
To: David Miller; +Cc: netdev, Florian Westphal
Currently, we do not notice if new alternative gateways
are added. We can do it by checking for present neigh
entry. Also, gateways that are currently probed (NUD_INCOMPLETE)
can be skipped from round-robin probing.
Suggested-by: Florian Westphal <fw@strlen.de>
Signed-off-by: Julian Anastasov <ja@ssi.bg>
---
net/ipv4/fib_semantics.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/net/ipv4/fib_semantics.c b/net/ipv4/fib_semantics.c
index 6754c64..d4c6732 100644
--- a/net/ipv4/fib_semantics.c
+++ b/net/ipv4/fib_semantics.c
@@ -438,13 +438,15 @@ static int fib_detect_death(struct fib_info *fi, int order,
if (n) {
state = n->nud_state;
neigh_release(n);
+ } else {
+ return 0;
}
if (state == NUD_REACHABLE)
return 0;
if ((state & NUD_VALID) && order != dflt)
return 0;
if ((state & NUD_VALID) ||
- (*last_idx < 0 && order > dflt)) {
+ (*last_idx < 0 && order > dflt && state != NUD_INCOMPLETE)) {
*last_resort = fi;
*last_idx = order;
}
--
1.9.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net-next] ipv4: be more aggressive when probing alternative gateways
2015-07-23 7:39 [PATCH net-next] ipv4: be more aggressive when probing alternative gateways Julian Anastasov
@ 2015-07-27 3:57 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2015-07-27 3:57 UTC (permalink / raw)
To: ja; +Cc: netdev, fw
From: Julian Anastasov <ja@ssi.bg>
Date: Thu, 23 Jul 2015 10:39:35 +0300
> Currently, we do not notice if new alternative gateways
> are added. We can do it by checking for present neigh
> entry. Also, gateways that are currently probed (NUD_INCOMPLETE)
> can be skipped from round-robin probing.
>
> Suggested-by: Florian Westphal <fw@strlen.de>
> Signed-off-by: Julian Anastasov <ja@ssi.bg>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-07-27 3:57 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-07-23 7:39 [PATCH net-next] ipv4: be more aggressive when probing alternative gateways Julian Anastasov
2015-07-27 3:57 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).