From: Scott Wood <scottwood@freescale.com>
To: Claudiu Manoil <claudiu.manoil@freescale.com>
Cc: <netdev@vger.kernel.org>, "David S. Miller" <davem@davemloft.net>,
<arnd@arndb.de>
Subject: Re: [PATCH net-next v2] gianfar: Fix warnings when built on 64-bit
Date: Wed, 29 Jul 2015 11:06:01 -0500 [thread overview]
Message-ID: <1438185961.2993.335.camel@freescale.com> (raw)
In-Reply-To: <1438175586-11614-1-git-send-email-claudiu.manoil@freescale.com>
On Wed, 2015-07-29 at 16:13 +0300, Claudiu Manoil wrote:
> From: Scott Wood <scottwood@freescale.com>
>
> As part of defconfig consolidation using fragments, we'd like to be
> able to have the same drivers enabled on 32-bit and 64-bit. Gianfar
> happens to only exist on 32-bit systems, and when building the
> resulting 64-bit kernel warnings were produced.
>
> A couple of the warnings are trivial, but the rfbptr code has deeper
> issues. It uses the virtual address as the DMA address, which again,
> happens to work in the environments where this driver is currently
> used, but is not the right thing to do.
>
> Fixes: 45b679c9a3cc ("gianfar: Implement PAUSE frame generation
> support")
> Signed-off-by: Scott Wood <scottwood@freescale.com>
> Signed-off-by: Claudiu Manoil <claudiu.manoil@freescale.com>
>
> ---
> v2 - rebased/reworked on top of net-next (instead of net);
> - removed CONFIG_PM unrelated change;
Are you going to submit the CONFIG_PM change separately? It fixes a warning
when CONFIG_PM is not enabled.
-Scott
next prev parent reply other threads:[~2015-07-29 16:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-29 13:13 [PATCH net-next v2] gianfar: Fix warnings when built on 64-bit Claudiu Manoil
2015-07-29 16:06 ` Scott Wood [this message]
2015-07-30 7:48 ` Manoil Claudiu
2015-07-30 5:57 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1438185961.2993.335.camel@freescale.com \
--to=scottwood@freescale.com \
--cc=arnd@arndb.de \
--cc=claudiu.manoil@freescale.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).