From: Nicolas Schichan <nschichan@freebox.fr>
To: Daniel Borkmann <daniel@iogearbox.net>,
Alexei Starovoitov <ast@plumgrid.com>,
"David S. Miller" <davem@davemloft.net>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Nicolas Schichan <nschichan@freebox.fr>
Subject: [PATCH V2 net-next 1/6] test_bpf: avoid oopsing the kernel when generate_test_data() fails.
Date: Tue, 4 Aug 2015 15:19:07 +0200 [thread overview]
Message-ID: <1438694352-17469-2-git-send-email-nschichan@freebox.fr> (raw)
In-Reply-To: <1438694352-17469-1-git-send-email-nschichan@freebox.fr>
Signed-off-by: Nicolas Schichan <nschichan@freebox.fr>
Acked-by: Alexei Starovoitov <ast@plumgrid.com>
Acked-by: Daniel Borkmann <daniel@iogearbox.net>
---
lib/test_bpf.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/lib/test_bpf.c b/lib/test_bpf.c
index 3afddf2..6843d0b 100644
--- a/lib/test_bpf.c
+++ b/lib/test_bpf.c
@@ -4672,6 +4672,11 @@ static int run_one(const struct bpf_prog *fp, struct bpf_test *test)
break;
data = generate_test_data(test, i);
+ if (!data && !(test->aux & FLAG_NO_DATA)) {
+ pr_cont("data generation failed ");
+ err_cnt++;
+ break;
+ }
ret = __run_one(fp, data, runs, &duration);
release_test_data(test, data);
--
1.9.1
next prev parent reply other threads:[~2015-08-04 13:19 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-04 13:19 [PATCH V2 net-next 0/6] test_bpf improvements Nicolas Schichan
2015-08-04 13:19 ` Nicolas Schichan [this message]
2015-08-04 13:19 ` [PATCH V2 net-next 2/6] test_bpf: allow tests to specify an skb fragment Nicolas Schichan
2015-08-04 13:19 ` [PATCH V2 net-next 3/6] test_bpf: test LD_ABS and LD_IND instructions on fragmented skbs Nicolas Schichan
2015-08-04 13:19 ` [PATCH V2 net-next 4/6] test_bpf: add module parameters to filter the tests to run Nicolas Schichan
2015-08-04 15:46 ` Alexei Starovoitov
2015-08-04 13:19 ` [PATCH V2 net-next 5/6] test_bpf: add more tests for LD_ABS and LD_IND Nicolas Schichan
2015-08-04 13:19 ` [PATCH V2 net-next 6/6] test_bpf: add tests checking that JIT/interpreter sets A and X to 0 Nicolas Schichan
2015-08-07 5:02 ` [PATCH V2 net-next 0/6] test_bpf improvements David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1438694352-17469-2-git-send-email-nschichan@freebox.fr \
--to=nschichan@freebox.fr \
--cc=ast@plumgrid.com \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).