From: Shahed Shaikh <shahed.shaikh@qlogic.com>
To: <davem@davemloft.net>
Cc: <netdev@vger.kernel.org>, <Dept-GELinuxNICDev@qlogic.com>,
Shahed Shaikh <shahed.shaikh@qlogic.com>
Subject: [PATCH net-next 5/6] qlcnic: Don't use kzalloc unncecessarily for allocating large chunk of memory
Date: Fri, 7 Aug 2015 07:17:06 -0400 [thread overview]
Message-ID: <1438946227-11426-6-git-send-email-shahed.shaikh@qlogic.com> (raw)
In-Reply-To: <1438946227-11426-1-git-send-email-shahed.shaikh@qlogic.com>
From: Shahed Shaikh <shahed.shaikh@qlogic.com>
Driver allocates a large chunk of temporary buffer using kzalloc
to copy FW image. As there is no real need of this memory to be
physically contiguous, use vzalloc instead.
Signed-off-by: Shahed Shaikh <shahed.shaikh@qlogic.com>
---
.../net/ethernet/qlogic/qlcnic/qlcnic_83xx_init.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_init.c b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_init.c
index 753ea8b..bf89216 100644
--- a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_init.c
+++ b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_init.c
@@ -1384,7 +1384,7 @@ static int qlcnic_83xx_copy_fw_file(struct qlcnic_adapter *adapter)
size_t size;
u64 addr;
- temp = kzalloc(fw->size, GFP_KERNEL);
+ temp = vzalloc(fw->size);
if (!temp) {
release_firmware(fw);
fw_info->fw = NULL;
@@ -1430,7 +1430,7 @@ static int qlcnic_83xx_copy_fw_file(struct qlcnic_adapter *adapter)
exit:
release_firmware(fw);
fw_info->fw = NULL;
- kfree(temp);
+ vfree(temp);
return ret;
}
--
1.5.6
next prev parent reply other threads:[~2015-08-07 12:02 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-07 11:17 [PATCH net-next 0/6] qlcnic: enhancements Shahed Shaikh
2015-08-07 11:17 ` [PATCH net-next 1/6] qlcnic: Rearrange ordering of header files inclusion Shahed Shaikh
2015-08-07 11:17 ` [PATCH net-next 2/6] qlcnic: Add support to enable capability to extend minidump for iSCSI Shahed Shaikh
2015-08-07 11:17 ` [PATCH net-next 3/6] qlcnic: Print firmware minidump buffer and template header addresses Shahed Shaikh
2015-08-07 11:17 ` [PATCH net-next 4/6] qlcnic: Add new VF device ID 0x8C30 Shahed Shaikh
2015-08-07 11:17 ` Shahed Shaikh [this message]
2015-08-07 11:17 ` [PATCH net-next 6/6] qlcnic: Update version to 5.3.63 Shahed Shaikh
2015-08-10 20:34 ` [PATCH net-next 0/6] qlcnic: enhancements David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1438946227-11426-6-git-send-email-shahed.shaikh@qlogic.com \
--to=shahed.shaikh@qlogic.com \
--cc=Dept-GELinuxNICDev@qlogic.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).