* [PATCH v2 net-next] bpf: fix bpf_perf_event_read() loop upper bound
@ 2015-08-12 14:57 Wei-Chun Chao
2015-08-12 15:58 ` Daniel Borkmann
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Wei-Chun Chao @ 2015-08-12 14:57 UTC (permalink / raw)
To: netdev; +Cc: davem, ast, xiakaixu
Verifier rejects programs incorrectly.
Fixes: 35578d798400 ("bpf: Implement function bpf_perf_event_read()")
Cc: Kaixu Xia <xiakaixu@huawei.com>
Cc: Alexei Starovoitov <ast@plumgrid.com>
Signed-off-by: Wei-Chun Chao <weichunc@plumgrid.com>
---
v2: better subject line
---
kernel/bpf/verifier.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/bpf/verifier.c b/kernel/bpf/verifier.c
index 48e1c71..ed12e38 100644
--- a/kernel/bpf/verifier.c
+++ b/kernel/bpf/verifier.c
@@ -853,7 +853,7 @@ static int check_map_func_compatibility(struct bpf_map *map, int func_id)
if (!map)
return 0;
- for (i = 0; i <= ARRAY_SIZE(func_limit); i++) {
+ for (i = 0; i < ARRAY_SIZE(func_limit); i++) {
bool_map = (map->map_type == func_limit[i].map_type);
bool_func = (func_id == func_limit[i].func_id);
/* only when map & func pair match it can continue.
--
1.9.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH v2 net-next] bpf: fix bpf_perf_event_read() loop upper bound
2015-08-12 14:57 [PATCH v2 net-next] bpf: fix bpf_perf_event_read() loop upper bound Wei-Chun Chao
@ 2015-08-12 15:58 ` Daniel Borkmann
2015-08-12 16:21 ` Alexei Starovoitov
2015-08-12 23:43 ` David Miller
2 siblings, 0 replies; 4+ messages in thread
From: Daniel Borkmann @ 2015-08-12 15:58 UTC (permalink / raw)
To: Wei-Chun Chao; +Cc: netdev, davem, ast, xiakaixu
On 08/12/2015 04:57 PM, Wei-Chun Chao wrote:
> Verifier rejects programs incorrectly.
>
> Fixes: 35578d798400 ("bpf: Implement function bpf_perf_event_read()")
> Cc: Kaixu Xia <xiakaixu@huawei.com>
> Cc: Alexei Starovoitov <ast@plumgrid.com>
> Signed-off-by: Wei-Chun Chao <weichunc@plumgrid.com>
Acked-by: Daniel Borkmann <daniel@iogearbox.net>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH v2 net-next] bpf: fix bpf_perf_event_read() loop upper bound
2015-08-12 14:57 [PATCH v2 net-next] bpf: fix bpf_perf_event_read() loop upper bound Wei-Chun Chao
2015-08-12 15:58 ` Daniel Borkmann
@ 2015-08-12 16:21 ` Alexei Starovoitov
2015-08-12 23:43 ` David Miller
2 siblings, 0 replies; 4+ messages in thread
From: Alexei Starovoitov @ 2015-08-12 16:21 UTC (permalink / raw)
To: Wei-Chun Chao, netdev; +Cc: davem, xiakaixu
On 8/12/15 7:57 AM, Wei-Chun Chao wrote:
> Verifier rejects programs incorrectly.
>
> Fixes: 35578d798400 ("bpf: Implement function bpf_perf_event_read()")
> Cc: Kaixu Xia <xiakaixu@huawei.com>
> Cc: Alexei Starovoitov <ast@plumgrid.com>
> Signed-off-by: Wei-Chun Chao <weichunc@plumgrid.com>
thanks a lot for tracking it down!
Acked-by: Alexei Starovoitov <ast@plumgrid.com>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH v2 net-next] bpf: fix bpf_perf_event_read() loop upper bound
2015-08-12 14:57 [PATCH v2 net-next] bpf: fix bpf_perf_event_read() loop upper bound Wei-Chun Chao
2015-08-12 15:58 ` Daniel Borkmann
2015-08-12 16:21 ` Alexei Starovoitov
@ 2015-08-12 23:43 ` David Miller
2 siblings, 0 replies; 4+ messages in thread
From: David Miller @ 2015-08-12 23:43 UTC (permalink / raw)
To: weichunc; +Cc: netdev, ast, xiakaixu
From: Wei-Chun Chao <weichunc@plumgrid.com>
Date: Wed, 12 Aug 2015 07:57:12 -0700
> Verifier rejects programs incorrectly.
>
> Fixes: 35578d798400 ("bpf: Implement function bpf_perf_event_read()")
> Cc: Kaixu Xia <xiakaixu@huawei.com>
> Cc: Alexei Starovoitov <ast@plumgrid.com>
> Signed-off-by: Wei-Chun Chao <weichunc@plumgrid.com>
> ---
>
> v2: better subject line
Applied, thanks.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-08-12 23:43 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-08-12 14:57 [PATCH v2 net-next] bpf: fix bpf_perf_event_read() loop upper bound Wei-Chun Chao
2015-08-12 15:58 ` Daniel Borkmann
2015-08-12 16:21 ` Alexei Starovoitov
2015-08-12 23:43 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).