* [PATCH net-next] ipv6: remove unnecessary include
@ 2015-08-14 22:13 Ian Morris
2015-08-17 21:34 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Ian Morris @ 2015-08-14 22:13 UTC (permalink / raw)
To: netdev; +Cc: Ian Morris
printk.h does not need to be explicitly included as we include kernel.h
which already called it.
Signed-off-by: Ian Morris <ipm@chirality.org.uk>
---
net/ipv6/ip6_offload.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/net/ipv6/ip6_offload.c b/net/ipv6/ip6_offload.c
index 08b6204..1cb2dc7 100644
--- a/net/ipv6/ip6_offload.c
+++ b/net/ipv6/ip6_offload.c
@@ -12,7 +12,6 @@
#include <linux/socket.h>
#include <linux/netdevice.h>
#include <linux/skbuff.h>
-#include <linux/printk.h>
#include <net/protocol.h>
#include <net/ipv6.h>
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net-next] ipv6: remove unnecessary include
2015-08-14 22:13 [PATCH net-next] ipv6: remove unnecessary include Ian Morris
@ 2015-08-17 21:34 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2015-08-17 21:34 UTC (permalink / raw)
To: ipm; +Cc: netdev
From: Ian Morris <ipm@chirality.org.uk>
Date: Fri, 14 Aug 2015 23:13:19 +0100
> printk.h does not need to be explicitly included as we include kernel.h
> which already called it.
>
> Signed-off-by: Ian Morris <ipm@chirality.org.uk>
We should not rely on such things and include explicitly the headers
that directly provide the interfaces we wish to use.
I'm not applying this, sorry.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-08-17 21:34 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-08-14 22:13 [PATCH net-next] ipv6: remove unnecessary include Ian Morris
2015-08-17 21:34 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).