[PATCH] ethtool: Dump eeprom info for soldered on modules

[PATCH] ethtool: Dump eeprom info for soldered on modules

[Andrew Lunn]

Modules which are soldered onto the motherboard may also use the sff8079
EEPROM format. Dump these in the same way as SFP modules.

Signed-off-by: Andrew Lunn <andrew@lunn.ch>
---
 sfpid.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sfpid.c b/sfpid.c
index b1a5044..0b5cd62 100644
--- a/sfpid.c
+++ b/sfpid.c
@@ -401,7 +401,7 @@ static void sff8079_show_options(const __u8 *id)
 void sff8079_show_all(const __u8 *id)
 {
 	sff8079_show_identifier(id);
-	if ((id[0] == 0x03) && (id[1] == 0x04)) {
+	if (((id[0] == 0x02) || (id[0] == 0x03)) && (id[1] == 0x04)) {
 		sff8079_show_ext_identifier(id);
 		sff8079_show_connector(id);
 		sff8079_show_transceiver(id);
-- 
2.1.4

Re: [PATCH] ethtool: Dump eeprom info for soldered on modules

[Andrew Lunn]

On Sun, Aug 16, 2015 at 04:05:18AM +0200, Andrew Lunn wrote:
> Modules which are soldered onto the motherboard may also use the sff8079
> EEPROM format. Dump these in the same way as SFP modules.

Hi Ben

I posted this patch two weeks ago. Since this is my first ethtool
patch, i've no idea what your response time usually is. Do i need to
repost? Send a gentle reminder? Or just wait a bit longer?

Thanks
	Andrew

> 
> Signed-off-by: Andrew Lunn <andrew@lunn.ch>
> ---
>  sfpid.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/sfpid.c b/sfpid.c
> index b1a5044..0b5cd62 100644
> --- a/sfpid.c
> +++ b/sfpid.c
> @@ -401,7 +401,7 @@ static void sff8079_show_options(const __u8 *id)
>  void sff8079_show_all(const __u8 *id)
>  {
>  	sff8079_show_identifier(id);
> -	if ((id[0] == 0x03) && (id[1] == 0x04)) {
> +	if (((id[0] == 0x02) || (id[0] == 0x03)) && (id[1] == 0x04)) {
>  		sff8079_show_ext_identifier(id);
>  		sff8079_show_connector(id);
>  		sff8079_show_transceiver(id);
> -- 
> 2.1.4
> 

Re: [PATCH] ethtool: Dump eeprom info for soldered on modules

[Ben Hutchings]

[-- Attachment #1: Type: text/plain, Size: 363 bytes --]

On Sun, 2015-08-16 at 04:05 +0200, Andrew Lunn wrote:
> Modules which are soldered onto the motherboard may also use the 
> sff8079
> EEPROM format. Dump these in the same way as SFP modules.
> 
> Signed-off-by: Andrew Lunn <andrew@lunn.ch>
[...]

Applied, thanks.

Ben.

-- 
Ben Hutchings
friends: People who know you well, but like you anyway.


[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 811 bytes --]