From: Johannes Berg <johannes@sipsolutions.net>
To: Phil Sutter <phil@nwl.cc>, netdev@vger.kernel.org
Cc: brouer@redhat.com, davem@davemloft.net
Subject: Re: [PATCH 15/21] net: mac80211_hwsim: convert to using IFF_NO_QUEUE
Date: Tue, 18 Aug 2015 10:43:55 +0200 [thread overview]
Message-ID: <1439887435.2455.0.camel@sipsolutions.net> (raw)
In-Reply-To: <1439886649-24166-16-git-send-email-phil@nwl.cc>
On Tue, 2015-08-18 at 10:30 +0200, Phil Sutter wrote:
> Signed-off-by: Phil Sutter <phil@nwl.cc>
> Cc: Johannes Berg <johannes@sipsolutions.net>
> ---
> drivers/net/wireless/mac80211_hwsim.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/wireless/mac80211_hwsim.c
> b/drivers/net/wireless/mac80211_hwsim.c
> index 99e873d..a1dbcb2 100644
> --- a/drivers/net/wireless/mac80211_hwsim.c
> +++ b/drivers/net/wireless/mac80211_hwsim.c
> @@ -2676,7 +2676,7 @@ static void hwsim_mon_setup(struct net_device
> *dev)
> dev->netdev_ops = &hwsim_netdev_ops;
> dev->destructor = free_netdev;
> ether_setup(dev);
> - dev->tx_queue_len = 0;
> + dev->priv_flags |= IFF_NO_QUEUE;
>
Fine with me; Dave, are you going to pick up the entire series
(presumably there was one, I only got this patch)?
Note that there's no TX possible on this particular netdev anyway.
johannes
next prev parent reply other threads:[~2015-08-18 8:44 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-18 8:30 [PATCH 00/21] net: Convert drivers to IFF_NO_QUEUE and cleanup afterwards Phil Sutter
2015-08-18 8:30 ` [PATCH 01/21] net: veth: enable noqueue operation by default Phil Sutter
2015-08-18 8:30 ` [PATCH 02/21] net: dummy: convert to using IFF_NO_QUEUE Phil Sutter
2015-08-18 8:30 ` [PATCH 03/21] net: geneve: " Phil Sutter
2015-08-18 8:30 ` [PATCH 04/21] net: loopback: " Phil Sutter
2015-08-18 8:30 ` [PATCH 05/21] net: nlmon: " Phil Sutter
2015-08-18 8:30 ` [PATCH 06/21] net: team: " Phil Sutter
2015-08-18 8:30 ` [PATCH 07/21] net: vxlan: " Phil Sutter
2015-08-18 8:30 ` [PATCH 08/21] net: 8021q: " Phil Sutter
2015-08-18 8:30 ` [PATCH 09/21] net: bridge: " Phil Sutter
2015-08-18 8:30 ` [PATCH 10/21] net: 6lowpan: " Phil Sutter
2015-08-18 8:30 ` [PATCH 11/21] net: bonding: " Phil Sutter
2015-08-18 8:30 ` [PATCH 12/21] net: ipvlan: " Phil Sutter
2015-08-18 8:30 ` [PATCH 13/21] net: dsa: " Phil Sutter
2015-08-18 8:30 ` [PATCH 14/21] net: hostap: " Phil Sutter
2015-08-18 8:30 ` [PATCH 15/21] net: mac80211_hwsim: " Phil Sutter
2015-08-18 8:30 ` [PATCH 16/21] net: batman-adv: " Phil Sutter
2015-08-18 8:30 ` [PATCH 17/21] net: hsr: " Phil Sutter
2015-08-18 8:30 ` [PATCH 18/21] net: caif: " Phil Sutter
2015-08-18 8:30 ` [PATCH 19/21] staging: wilc1000: " Phil Sutter
2015-08-18 8:30 ` [PATCH 20/21] net: warn if drivers set tx_queue_len = 0 Phil Sutter
2015-08-18 8:30 ` [PATCH 21/21] net: sched: drop all special handling of tx_queue_len == 0 Phil Sutter
2015-08-18 14:47 ` [PATCH 20/21] net: warn if drivers set tx_queue_len = 0 Eric Dumazet
2015-08-18 18:14 ` Phil Sutter
2015-08-19 18:39 ` Phil Sutter
2015-08-19 20:21 ` Phil Sutter
2015-08-19 20:31 ` Eric Dumazet
2015-08-19 20:33 ` Eric Dumazet
2015-08-19 21:04 ` Phil Sutter
2015-08-18 8:43 ` Johannes Berg [this message]
2015-08-18 18:54 ` [PATCH 15/21] net: mac80211_hwsim: convert to using IFF_NO_QUEUE David Miller
2015-08-18 18:56 ` [PATCH 00/21] net: Convert drivers to IFF_NO_QUEUE and cleanup afterwards David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1439887435.2455.0.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=brouer@redhat.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=phil@nwl.cc \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).