From: Eric Dumazet <eric.dumazet@gmail.com>
To: "Li,Rongqing" <lirongqing@baidu.com>,
Eric Dumazet <eric.dumazet@gmail.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: 答复: [PATCH][next-next][v2] netlink: avoid to allocate full skb when sending to many devices
Date: Fri, 21 Sep 2018 07:54:37 -0700 [thread overview]
Message-ID: <143e1ef8-c46e-f778-727e-df5140cf8e54@gmail.com> (raw)
In-Reply-To: <2AD939572F25A448A3AE3CAEA61328C237A41FCA@BC-MAIL-M30.internal.baidu.com>
On 09/20/2018 08:27 PM, Li,Rongqing wrote:
>
> The below change seems simple, but it increase skb allocation and
> free one time,
Seem fine to me. An extra skb_clone() for vmalloc-skb-users is absolute noise,
compared to vmalloc()vfree() cost.
Thanks.
next prev parent reply other threads:[~2018-09-21 20:43 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-20 8:54 [PATCH][next-next][v2] netlink: avoid to allocate full skb when sending to many devices Li RongQing
2018-09-20 13:43 ` Eric Dumazet
2018-09-20 13:51 ` Eric Dumazet
2018-09-21 3:27 ` 答复: " Li,Rongqing
2018-09-21 14:54 ` Eric Dumazet [this message]
2018-09-21 19:08 ` Cong Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=143e1ef8-c46e-f778-727e-df5140cf8e54@gmail.com \
--to=eric.dumazet@gmail.com \
--cc=lirongqing@baidu.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).