From mboxrd@z Thu Jan  1 00:00:00 1970
From: Eric Dumazet <eric.dumazet@gmail.com>
Subject: =?UTF-8?Q?Re:_=e7=ad=94=e5=a4=8d:_[PATCH][next-next][v2]_netlink:_a?=
 =?UTF-8?Q?void_to_allocate_full_skb_when_sending_to_many_devices?=
Date: Fri, 21 Sep 2018 07:54:37 -0700
Message-ID: <143e1ef8-c46e-f778-727e-df5140cf8e54@gmail.com>
References: <1537433690-24335-1-git-send-email-lirongqing@baidu.com>
 <a9b4a4b9-04c4-bf55-3f08-b7889524374a@gmail.com>
 <549f8bea-bd5f-70da-bbf3-c2331ffbf964@gmail.com>
 <2AD939572F25A448A3AE3CAEA61328C237A41FCA@BC-MAIL-M30.internal.baidu.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
To: "Li,Rongqing" <lirongqing@baidu.com>,
        Eric Dumazet <eric.dumazet@gmail.com>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>
Return-path: <netdev-owner@vger.kernel.org>
Received: from mail-pl1-f169.google.com ([209.85.214.169]:33076 "EHLO
        mail-pl1-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S2389547AbeIUUnx (ORCPT
        <rfc822;netdev@vger.kernel.org>); Fri, 21 Sep 2018 16:43:53 -0400
Received: by mail-pl1-f169.google.com with SMTP id b97-v6so6102562plb.0
        for <netdev@vger.kernel.org>; Fri, 21 Sep 2018 07:54:40 -0700 (PDT)
In-Reply-To: <2AD939572F25A448A3AE3CAEA61328C237A41FCA@BC-MAIL-M30.internal.baidu.com>
Content-Language: en-US
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>



On 09/20/2018 08:27 PM, Li,Rongqing wrote:
> 
> The below change seems simple, but it increase skb allocation and
> free one time,  

Seem fine to me. An extra skb_clone() for vmalloc-skb-users is absolute noise,
compared to vmalloc()vfree() cost.

Thanks.