* Re: [PATCH] lib/Makefile: remove CONFIG_AVERAGE build rule
[not found] <1440151514-5796-1-git-send-email-valentinrothberg@gmail.com>
@ 2015-08-21 10:13 ` Johannes Berg
2015-08-26 0:21 ` David Miller
0 siblings, 1 reply; 4+ messages in thread
From: Johannes Berg @ 2015-08-21 10:13 UTC (permalink / raw)
To: Valentin Rothberg, davem@davemloft.net,
linux-kernel@vger.kernel.org; +Cc: netdev
On Fri, 2015-08-21 at 10:05 +0000, Valentin Rothberg wrote:
> The Kconfig option AVERAGE and its implementation has been removed by
> commit f4e774f55fe0 ("average: remove out-of-line implementation").
> Remove the dead build rule in lib/Makefile.
D'oh, sorry about that.
Reviewed-by: Johannes Berg <johannes@sipsolutions.net>
[reproducing patch in full for netdev]
> Signed-off-by: Valentin Rothberg <valentinrothberg@gmail.com>
> ---
> I detected the issue with scripts/checkkconfigsymbols.py
>
> lib/Makefile | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/lib/Makefile b/lib/Makefile
> index 51e1d761f0b9..f32d342b75de 100644
> --- a/lib/Makefile
> +++ b/lib/Makefile
> @@ -143,8 +143,6 @@ obj-$(CONFIG_GENERIC_ATOMIC64) += atomic64.o
>
> obj-$(CONFIG_ATOMIC64_SELFTEST) += atomic64_test.o
>
> -obj-$(CONFIG_AVERAGE) += average.o
> -
> obj-$(CONFIG_CPU_RMAP) += cpu_rmap.o
>
> obj-$(CONFIG_CORDIC) += cordic.o
> --
> 1.9.1
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] lib/Makefile: remove CONFIG_AVERAGE build rule
2015-08-21 10:13 ` [PATCH] lib/Makefile: remove CONFIG_AVERAGE build rule Johannes Berg
@ 2015-08-26 0:21 ` David Miller
0 siblings, 0 replies; 4+ messages in thread
From: David Miller @ 2015-08-26 0:21 UTC (permalink / raw)
To: johannes; +Cc: valentinrothberg, linux-kernel, netdev
From: Johannes Berg <johannes@sipsolutions.net>
Date: Fri, 21 Aug 2015 12:13:23 +0200
> On Fri, 2015-08-21 at 10:05 +0000, Valentin Rothberg wrote:
>> The Kconfig option AVERAGE and its implementation has been removed by
>> commit f4e774f55fe0 ("average: remove out-of-line implementation").
>> Remove the dead build rule in lib/Makefile.
>
> D'oh, sorry about that.
>
> Reviewed-by: Johannes Berg <johannes@sipsolutions.net>
>
> [reproducing patch in full for netdev]
The full patch needs to be resubmitted to netdev so that it gets
queued up in patchwork, thanks.
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] lib/Makefile: remove CONFIG_AVERAGE build rule
@ 2015-08-26 13:36 Valentin Rothberg
2015-08-26 17:54 ` David Miller
0 siblings, 1 reply; 4+ messages in thread
From: Valentin Rothberg @ 2015-08-26 13:36 UTC (permalink / raw)
To: johannes.berg, davem, linux-kernel, netdev; +Cc: Valentin Rothberg
The Kconfig option AVERAGE and its implementation has been removed by
commit f4e774f55fe0 ("average: remove out-of-line implementation").
Remove the dead build rule in lib/Makefile.
Signed-off-by: Valentin Rothberg <valentinrothberg@gmail.com>
Reviewed-by: Johannes Berg <johannes@sipsolutions.net>
---
I detected the issue with scripts/checkkconfigsymbols.py
David asked to resend the full patch netdev so that it gets queued
up in patchwork.
lib/Makefile | 2 --
1 file changed, 2 deletions(-)
diff --git a/lib/Makefile b/lib/Makefile
index 51e1d761f0b9..f32d342b75de 100644
--- a/lib/Makefile
+++ b/lib/Makefile
@@ -143,8 +143,6 @@ obj-$(CONFIG_GENERIC_ATOMIC64) += atomic64.o
obj-$(CONFIG_ATOMIC64_SELFTEST) += atomic64_test.o
-obj-$(CONFIG_AVERAGE) += average.o
-
obj-$(CONFIG_CPU_RMAP) += cpu_rmap.o
obj-$(CONFIG_CORDIC) += cordic.o
--
1.9.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] lib/Makefile: remove CONFIG_AVERAGE build rule
2015-08-26 13:36 Valentin Rothberg
@ 2015-08-26 17:54 ` David Miller
0 siblings, 0 replies; 4+ messages in thread
From: David Miller @ 2015-08-26 17:54 UTC (permalink / raw)
To: valentinrothberg; +Cc: johannes.berg, linux-kernel, netdev
From: Valentin Rothberg <valentinrothberg@gmail.com>
Date: Wed, 26 Aug 2015 15:36:12 +0200
> The Kconfig option AVERAGE and its implementation has been removed by
> commit f4e774f55fe0 ("average: remove out-of-line implementation").
> Remove the dead build rule in lib/Makefile.
>
> Signed-off-by: Valentin Rothberg <valentinrothberg@gmail.com>
> Reviewed-by: Johannes Berg <johannes@sipsolutions.net>
Applied, thanks.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-08-26 17:54 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1440151514-5796-1-git-send-email-valentinrothberg@gmail.com>
2015-08-21 10:13 ` [PATCH] lib/Makefile: remove CONFIG_AVERAGE build rule Johannes Berg
2015-08-26 0:21 ` David Miller
2015-08-26 13:36 Valentin Rothberg
2015-08-26 17:54 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).