From: Jiri Pirko <jiri@resnulli.us>
To: netdev@vger.kernel.org
Cc: davem@davemloft.net, idosch@mellanox.com, eladr@mellanox.com,
ogerlitz@mellanox.com, Jiri Pirko <jiri@mellanox.com>
Subject: [patch net-next 3/3] mlxsw: adjust log messages level in __mlxsw_emad_transmit
Date: Mon, 24 Aug 2015 16:45:47 +0200 [thread overview]
Message-ID: <1440427547-8539-4-git-send-email-jiri@resnulli.us> (raw)
In-Reply-To: <1440427547-8539-1-git-send-email-jiri@resnulli.us>
From: Jiri Pirko <jiri@mellanox.com>
When transmit fails, it is an error, not a warning.
Do not warn when timeout happens as that is handled by a counter.
Signed-off-by: Jiri Pirko <jiri@mellanox.com>
Signed-off-by: Ido Schimmel <idosch@mellanox.com>
Signed-off-by: Elad Raz <eladr@mellanox.com>
---
drivers/net/ethernet/mellanox/mlxsw/core.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/net/ethernet/mellanox/mlxsw/core.c b/drivers/net/ethernet/mellanox/mlxsw/core.c
index 6ee3f45..dfafb83 100644
--- a/drivers/net/ethernet/mellanox/mlxsw/core.c
+++ b/drivers/net/ethernet/mellanox/mlxsw/core.c
@@ -382,8 +382,8 @@ static int __mlxsw_emad_transmit(struct mlxsw_core *mlxsw_core,
err = mlxsw_core_skb_transmit(mlxsw_core->driver_priv, skb, tx_info);
if (err) {
- dev_warn(mlxsw_core->bus_info->dev, "Failed to transmit EMAD (tid=%llx)\n",
- mlxsw_core->emad.tid);
+ dev_err(mlxsw_core->bus_info->dev, "Failed to transmit EMAD (tid=%llx)\n",
+ mlxsw_core->emad.tid);
dev_kfree_skb(skb);
return err;
}
@@ -393,8 +393,8 @@ static int __mlxsw_emad_transmit(struct mlxsw_core *mlxsw_core,
!(mlxsw_core->emad.trans_active),
msecs_to_jiffies(MLXSW_EMAD_TIMEOUT_MS));
if (!ret) {
- dev_warn(mlxsw_core->bus_info->dev, "EMAD timed-out (tid=%llx)\n",
- mlxsw_core->emad.tid);
+ dev_dbg(mlxsw_core->bus_info->dev, "EMAD timed-out (tid=%llx)\n",
+ mlxsw_core->emad.tid);
mlxsw_core->emad.trans_active = false;
mlxsw_core->emad.stats.timeouts++;
return -EIO;
--
1.9.3
prev parent reply other threads:[~2015-08-24 14:45 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-24 14:45 [patch net-next 0/3] mlxsw: small driver update Jiri Pirko
2015-08-24 14:45 ` [patch net-next 1/3] mlxsw: Remove duplicate included header Jiri Pirko
2015-08-24 14:45 ` [patch net-next 2/3] mlxsw: expose EMAD transactions statistics via debugfs Jiri Pirko
2015-08-25 21:25 ` David Miller
2015-08-26 5:52 ` Jiri Pirko
2015-08-26 6:08 ` David Miller
2015-08-26 7:37 ` Jiri Pirko
2015-08-26 17:49 ` David Miller
2015-08-26 18:21 ` Scott Feldman
2015-08-26 18:36 ` Florian Fainelli
2015-08-27 0:26 ` David Miller
2015-08-27 5:40 ` Jiri Pirko
2015-08-27 6:01 ` David Miller
2015-08-27 6:27 ` Jiri Pirko
2015-08-27 6:36 ` David Miller
2015-08-27 6:40 ` Jiri Pirko
2015-09-16 13:14 ` Marcelo Ricardo Leitner
2015-08-24 14:45 ` Jiri Pirko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1440427547-8539-4-git-send-email-jiri@resnulli.us \
--to=jiri@resnulli.us \
--cc=davem@davemloft.net \
--cc=eladr@mellanox.com \
--cc=idosch@mellanox.com \
--cc=jiri@mellanox.com \
--cc=netdev@vger.kernel.org \
--cc=ogerlitz@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).