netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: <chenweilong@huawei.com>
To: <davem@davemloft.net>, <edumazet@google.com>,
	<alexander.h.duyck@redhat.com>, <willemb@google.com>,
	<hannes@stressinduktion.org>
Cc: <netdev@vger.kernel.org>
Subject: [PATCH net-next] net: Check frag_lists first to prevent data out of order
Date: Thu, 27 Aug 2015 08:56:05 +0800	[thread overview]
Message-ID: <1440636965-11552-1-git-send-email-chenweilong@huawei.com> (raw)

From: Weilong Chen <chenweilong@huawei.com>

When try to merge several skbs to prior one, if the frag_list is
used and the the last one is a small packet, once the condition
"len <= skb_tailroom(to)" is satisfied, we will get a wrong
packet!
This patch just check frag_lists before the condtion to prevent
this from happening.

Signed-off-by: Weilong Chen <chenweilong@huawei.com>
---
 net/core/skbuff.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/net/core/skbuff.c b/net/core/skbuff.c
index 8a725cc..d08edcb 100644
--- a/net/core/skbuff.c
+++ b/net/core/skbuff.c
@@ -4133,6 +4133,9 @@ bool skb_try_coalesce(struct sk_buff *to, struct sk_buff *from,
 	if (skb_cloned(to))
 		return false;
 
+	if (skb_has_frag_list(to) || skb_has_frag_list(from))
+		return false;
+
 	if (len <= skb_tailroom(to)) {
 		if (len)
 			BUG_ON(skb_copy_bits(from, 0, skb_put(to, len), len));
@@ -4140,9 +4143,6 @@ bool skb_try_coalesce(struct sk_buff *to, struct sk_buff *from,
 		return true;
 	}
 
-	if (skb_has_frag_list(to) || skb_has_frag_list(from))
-		return false;
-
 	if (skb_headlen(from) != 0) {
 		struct page *page;
 		unsigned int offset;
-- 
1.7.12

             reply	other threads:[~2015-08-27  0:56 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-27  0:56 chenweilong [this message]
2015-08-27  2:12 ` [PATCH net-next] net: Check frag_lists first to prevent data out of order Eric Dumazet
2015-08-27  2:23   ` Eric Dumazet
2015-08-28  3:35     ` Weilong Chen
2015-08-28  4:26       ` David Miller
2015-08-28  5:34         ` Weilong Chen
2015-08-28  4:37       ` Eric Dumazet
2015-08-28  5:33         ` Weilong Chen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1440636965-11552-1-git-send-email-chenweilong@huawei.com \
    --to=chenweilong@huawei.com \
    --cc=alexander.h.duyck@redhat.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=hannes@stressinduktion.org \
    --cc=netdev@vger.kernel.org \
    --cc=willemb@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).