From: Phil Sutter <phil@nwl.cc>
To: netdev@vger.kernel.org
Cc: davem@davemloft.net, eric.dumazet@gmail.com, brouer@redhat.com,
geert@linux-m68k.org
Subject: [net-next PATCH 1/4] net: fix IFF_NO_QUEUE for drivers using alloc_netdev
Date: Thu, 27 Aug 2015 21:21:36 +0200 [thread overview]
Message-ID: <1440703299-21243-2-git-send-email-phil@nwl.cc> (raw)
In-Reply-To: <1440703299-21243-1-git-send-email-phil@nwl.cc>
Printing a warning in alloc_netdev_mqs() if tx_queue_len is zero and
IFF_NO_QUEUE not set is not appropriate since drivers may use one of the
alloc_netdev* macros instead of alloc_etherdev*, thereby not
intentionally leaving tx_queue_len uninitialized. Instead check here if
tx_queue_len is zero and set IFF_NO_QUEUE, so the value of tx_queue_len
can be ignored in net/sched_generic.c.
Fixes: 906470c ("net: warn if drivers set tx_queue_len = 0")
Signed-off-by: Phil Sutter <phil@nwl.cc>
---
net/core/dev.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/core/dev.c b/net/core/dev.c
index b1f3f48..68156ef 100644
--- a/net/core/dev.c
+++ b/net/core/dev.c
@@ -6998,7 +6998,7 @@ struct net_device *alloc_netdev_mqs(int sizeof_priv, const char *name,
setup(dev);
if (!dev->tx_queue_len)
- printk(KERN_WARNING "%s uses DEPRECATED zero tx_queue_len - convert driver to use IFF_NO_QUEUE instead.\n", name);
+ dev->priv_flags |= IFF_NO_QUEUE;
dev->num_tx_queues = txqs;
dev->real_num_tx_queues = txqs;
--
2.1.2
next prev parent reply other threads:[~2015-08-27 19:21 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-27 19:21 [net-next PATCH 0/4] fixup IFF_NO_QUEUE conversion Phil Sutter
2015-08-27 19:21 ` Phil Sutter [this message]
2015-08-27 19:21 ` [net-next PATCH 2/4] net: sched: ignore tx_queue_len when assigning default qdisc Phil Sutter
2015-08-27 19:21 ` [net-next PATCH 3/4] net: sched: register noqueue qdisc Phil Sutter
2015-08-29 20:04 ` Sergei Shtylyov
2015-08-27 19:21 ` [net-next PATCH 4/4] net: sched: simplify attach_one_default_qdisc() Phil Sutter
2015-08-28 0:15 ` [net-next PATCH 0/4] fixup IFF_NO_QUEUE conversion David Miller
2015-09-01 7:52 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1440703299-21243-2-git-send-email-phil@nwl.cc \
--to=phil@nwl.cc \
--cc=brouer@redhat.com \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=geert@linux-m68k.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).