From: David Ahern <dsa@cumulusnetworks.com>
To: netdev@vger.kernel.org
Cc: David Ahern <dsa@cumulusnetworks.com>
Subject: [RFC PATCH net-next 2/3] net: Add L3 Rx handler to IPv4 processing
Date: Fri, 28 Aug 2015 17:34:22 -0700 [thread overview]
Message-ID: <1440808463-14526-3-git-send-email-dsa@cumulusnetworks.com> (raw)
In-Reply-To: <1440808463-14526-1-git-send-email-dsa@cumulusnetworks.com>
If an L3 RX handler has been set for the current skb device then the
skb is run through the NF_HOOK for NF_INET_PRE_ROUTING with a dummy
function to not further process the packet. From there the skb is passed
to the L3 RX handler. The L3 RX handler maintains the same semantics as
the current RX handler -- it can modify the skb and ask for another pass,
consume it or just ignore the packet and have it continue on.
Signed-off-by: David Ahern <dsa@cumulusnetworks.com>
---
net/ipv4/ip_input.c | 32 ++++++++++++++++++++++++++++++--
1 file changed, 30 insertions(+), 2 deletions(-)
diff --git a/net/ipv4/ip_input.c b/net/ipv4/ip_input.c
index f4fc8a77aaa7..75da9dc0e8f5 100644
--- a/net/ipv4/ip_input.c
+++ b/net/ipv4/ip_input.c
@@ -372,11 +372,17 @@ static int ip_rcv_finish(struct sock *sk, struct sk_buff *skb)
return NET_RX_DROP;
}
+static int ip_rcv_first_pass(struct sock *sk, struct sk_buff *skb)
+{
+ return 0;
+}
+
/*
* Main IP Receive routine.
*/
int ip_rcv(struct sk_buff *skb, struct net_device *dev, struct packet_type *pt, struct net_device *orig_dev)
{
+ rx_handler_func_t *rx_handler;
const struct iphdr *iph;
u32 len;
@@ -386,6 +392,8 @@ int ip_rcv(struct sk_buff *skb, struct net_device *dev, struct packet_type *pt,
if (skb->pkt_type == PACKET_OTHERHOST)
goto drop;
+another_round:
+ rx_handler = rcu_dereference(skb->dev->l3_rx_handler);
IP_UPD_PO_STATS_BH(dev_net(dev), IPSTATS_MIB_IN, skb->len);
@@ -453,9 +461,29 @@ int ip_rcv(struct sk_buff *skb, struct net_device *dev, struct packet_type *pt,
/* Must drop socket now because of tproxy. */
skb_orphan(skb);
+ if (rx_handler) {
+ int rc;
+
+ rc = NF_HOOK(NFPROTO_IPV4, NF_INET_PRE_ROUTING, NULL, skb,
+ dev, NULL, ip_rcv_first_pass);
+ if (rc != 0)
+ return rc;
+
+ switch (rx_handler(&skb)) {
+ case RX_HANDLER_CONSUMED:
+ return 0;
+ case RX_HANDLER_ANOTHER:
+ rx_handler = NULL;
+ goto another_round;
+ case RX_HANDLER_PASS:
+ return ip_rcv_finish(NULL, skb);
+ default:
+ pr_err("Invalid return for L3 rx_handler\n");
+ }
+ }
+
return NF_HOOK(NFPROTO_IPV4, NF_INET_PRE_ROUTING, NULL, skb,
- dev, NULL,
- ip_rcv_finish);
+ dev, NULL, ip_rcv_finish);
csum_error:
IP_INC_STATS_BH(dev_net(dev), IPSTATS_MIB_CSUMERRORS);
--
1.9.1
next prev parent reply other threads:[~2015-08-29 0:34 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-29 0:34 [RFC PATCH net-next 0/3] L3 RX handler David Ahern
2015-08-29 0:34 ` [RFC PATCH net-next 1/3] net: Introduce L3 RX Handler David Ahern
2015-08-29 0:34 ` David Ahern [this message]
2015-08-29 0:34 ` [RFC PATCH net-next 3/3] net: Change VRF driver to use the new L3 RX handler David Ahern
2015-08-29 1:31 ` [RFC PATCH net-next 0/3] " Eric Dumazet
2015-08-29 5:14 ` David Miller
2015-08-29 15:20 ` David Ahern
2015-08-29 18:02 ` Tom Herbert
2015-08-31 3:59 ` David Ahern
2015-08-29 5:14 ` David Miller
2015-08-29 15:05 ` David Ahern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1440808463-14526-3-git-send-email-dsa@cumulusnetworks.com \
--to=dsa@cumulusnetworks.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).