From: Lars Persson <lars.persson@axis.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: "David S. Miller" <davem@davemloft.net>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ethernet: synopsys: SYNOPSYS_DWC_ETH_QOS should depend on HAS_DMA
Date: Fri, 4 Sep 2015 15:35:22 +0200 [thread overview]
Message-ID: <1441373722.8749.3.camel@axis.com> (raw)
In-Reply-To: <1441370652-13762-1-git-send-email-geert@linux-m68k.org>
On Fri, 2015-09-04 at 14:44 +0200, Geert Uytterhoeven wrote:
> If NO_DMA=y:
>
> ERROR: "dma_alloc_coherent" [drivers/net/ethernet/synopsys/dwc_eth_qos.ko] undefined!
> ERROR: "dma_free_coherent" [drivers/net/ethernet/synopsys/dwc_eth_qos.ko] undefined!
> ERROR: "dma_unmap_single" [drivers/net/ethernet/synopsys/dwc_eth_qos.ko] undefined!
> ERROR: "dma_map_page" [drivers/net/ethernet/synopsys/dwc_eth_qos.ko] undefined!
> ERROR: "dma_mapping_error" [drivers/net/ethernet/synopsys/dwc_eth_qos.ko] undefined!
> ERROR: "dma_map_single" [drivers/net/ethernet/synopsys/dwc_eth_qos.ko] undefined!
>
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
Acked-by: Lars Persson <larper@axis.com>
> ---
> drivers/net/ethernet/synopsys/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/synopsys/Kconfig b/drivers/net/ethernet/synopsys/Kconfig
> index a8f315106742d9b1..8276ee5a7d541b2e 100644
> --- a/drivers/net/ethernet/synopsys/Kconfig
> +++ b/drivers/net/ethernet/synopsys/Kconfig
> @@ -20,7 +20,7 @@ config SYNOPSYS_DWC_ETH_QOS
> select PHYLIB
> select CRC32
> select MII
> - depends on OF
> + depends on OF && HAS_DMA
> ---help---
> This driver supports the DWC Ethernet QoS from Synopsys
>
next prev parent reply other threads:[~2015-09-04 13:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-04 12:44 [PATCH] ethernet: synopsys: SYNOPSYS_DWC_ETH_QOS should depend on HAS_DMA Geert Uytterhoeven
2015-09-04 13:35 ` Lars Persson [this message]
2015-09-07 2:49 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1441373722.8749.3.camel@axis.com \
--to=lars.persson@axis.com \
--cc=davem@davemloft.net \
--cc=geert@linux-m68k.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).