From: Ben Hutchings <ben@decadent.org.uk>
To: Hadar Hen Zion <hadarh@mellanox.com>
Cc: netdev@vger.kernel.org, _govind@gmx.com,
Amir Vadai <amirv@mellanox.com>,
Or Gerlitz <ogerlitz@mellanox.com>, Tal Alon <talal@mellanox.com>
Subject: Re: [PATCH ethtool V3 1/2] ethtool: Add copybreak support
Date: Sat, 05 Sep 2015 10:50:01 +0100 [thread overview]
Message-ID: <1441446601.13323.6.camel@decadent.org.uk> (raw)
In-Reply-To: <1434024928-33177-2-git-send-email-hadarh@mellanox.com>
[-- Attachment #1: Type: text/plain, Size: 637 bytes --]
On Thu, 2015-06-11 at 15:15 +0300, Hadar Hen Zion wrote:
> From: Govindarajulu Varadarajan <_govind@gmx.com>
>
> Add support for setting/getting driver's tx/rx_copybreak value.
>
> Copybreak is handled through a new ethtool tunable interface.
>
> The kernel support was added in 3.18, commit f0db9b07341 "ethtool:
> Add generic options for tunables"
[...]
So why have you sent a patch that only handles copy-break? The kernel
tells us the type of each tunable and ethtool should use that to decide
how to print and parse values.
Ben.
--
Ben Hutchings
friends: People who know you well, but like you anyway.
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 811 bytes --]
next prev parent reply other threads:[~2015-09-05 10:41 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-11 12:15 [PATCH ethtool V3 0/2] Add copybreak support Hadar Hen Zion
2015-06-11 12:15 ` [PATCH ethtool V3 1/2] ethtool: " Hadar Hen Zion
2015-09-05 9:48 ` Ben Hutchings
2015-09-05 9:50 ` Ben Hutchings [this message]
2015-06-11 12:15 ` [PATCH ethtool V3 2/2] ethtool.8.in: Add man page for tunable copybreak Hadar Hen Zion
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1441446601.13323.6.camel@decadent.org.uk \
--to=ben@decadent.org.uk \
--cc=_govind@gmx.com \
--cc=amirv@mellanox.com \
--cc=hadarh@mellanox.com \
--cc=netdev@vger.kernel.org \
--cc=ogerlitz@mellanox.com \
--cc=talal@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox