netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Felix Kaiser <felix.kaiser@fxkr.net>
To: Jiri Benc <jbenc@redhat.com>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH] ip link/addr show: add empty line between interfaces
Date: Mon, 07 Sep 2015 17:38:48 +0200	[thread overview]
Message-ID: <1441639971-sup-8473@zero> (raw)
In-Reply-To: <20150907144609.3ec9f4d0@griffin>

Excerpts from Jiri Benc's message of 2015-09-07 14:46:09 +0200:
> Or makes the readability worse by requiring more scrolling, depending
> on number of interfaces you have and your taste.

Of course it's slightly subjective, but I think it improves readability
quite a bit *especially* on servers with many interfaces.

Without the additional lines, you can obviously fit more on one screen,
but I don't think it's much, and I think that once you have a screenful
of text, adding some whitespace makes it much, much easier to focus on
the individual sections.

> Many users prefer the current format.

I've met users who prefer ifconfigs format (and have literally told me
that they find ips hard to read), and I've met users who use a shell
alias to hack newlines in (which is the motivation for this patch), and
everyone that I've shown side-by-side comparisons has been supportive.

> Also, as sad as it is, there are scripts out there that parse ip output
> and I have no doubts this would break them.

I'm aware.

My opinion is that if someone parses that, they deserve the opportunity
to fix their code. At the very least they could have used -oneline!

The default output format is clearly intended for humans; it seems
like no attention at all has been given to parseability. And that's
as it should be - since, because it requires the fewest keystrokes,
that's the format that nearly all interactive users are going to see,
and the output should be optimized for them.

If absolute compatibility even for badly written scripts that misuse
the tool had to be maintained then that'd mean that no improvements
could ever be made, and that'd be sad.

Felix

  reply	other threads:[~2015-09-07 15:38 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-06 11:01 [PATCH] ip link/addr show: add empty line between interfaces Felix Kaiser
2015-09-07 12:46 ` Jiri Benc
2015-09-07 15:38   ` Felix Kaiser [this message]
2015-09-07 15:54     ` Jiri Benc
2015-09-07 18:09       ` Stephen Hemminger
2015-09-07 19:57         ` Felix Kaiser

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1441639971-sup-8473@zero \
    --to=felix.kaiser@fxkr.net \
    --cc=jbenc@redhat.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).