From: Phil Sutter <phil@nwl.cc>
To: stephen@networkplumber.org
Cc: bridge@lists.linux-foundation.org, netdev@vger.kernel.org
Subject: [net-next PATCH] net: bridge: fix for bridging 802.1Q without REORDER_HDR
Date: Fri, 11 Sep 2015 21:22:03 +0200 [thread overview]
Message-ID: <1441999323-29381-1-git-send-email-phil@nwl.cc> (raw)
When forwarding packets from an 802.1Q interface with REORDER_HDR set to
zero, the VLAN header previously inserted by vlan_do_receive() needs to
be stripped from the packet and the mac_header adjustment undone,
otherwise a tagged frame with first four bytes missing will be
transmitted.
Signed-off-by: Phil Sutter <phil@nwl.cc>
---
net/bridge/br_input.c | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/net/bridge/br_input.c b/net/bridge/br_input.c
index f921a5d..e4e3fc7 100644
--- a/net/bridge/br_input.c
+++ b/net/bridge/br_input.c
@@ -288,6 +288,16 @@ rx_handler_result_t br_handle_frame(struct sk_buff **pskb)
}
forward:
+ if (is_vlan_dev(skb->dev) &&
+ !(vlan_dev_priv(skb->dev)->flags & VLAN_FLAG_REORDER_HDR)) {
+ unsigned int offset = skb->data - skb_mac_header(skb);
+
+ skb_push(skb, offset);
+ memmove(skb->data + VLAN_HLEN, skb->data, 2 * ETH_ALEN);
+ skb->mac_header += VLAN_HLEN;
+ skb_pull(skb, offset);
+ skb_reset_mac_len(skb);
+ }
switch (p->state) {
case BR_STATE_FORWARDING:
rhook = rcu_dereference(br_should_route_hook);
--
2.1.2
next reply other threads:[~2015-09-11 19:22 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-11 19:22 Phil Sutter [this message]
2015-09-11 19:24 ` [net-next PATCH] net: bridge: fix for bridging 802.1Q without REORDER_HDR Stephen Hemminger
2015-09-11 20:20 ` Phil Sutter
2015-09-14 18:21 ` Vlad Yasevich
2015-09-14 20:06 ` Phil Sutter
2015-09-15 15:11 ` Vlad Yasevich
2015-09-15 18:17 ` Phil Sutter
2015-09-16 2:36 ` Vlad Yasevich
2015-09-16 10:41 ` Phil Sutter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1441999323-29381-1-git-send-email-phil@nwl.cc \
--to=phil@nwl.cc \
--cc=bridge@lists.linux-foundation.org \
--cc=netdev@vger.kernel.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).