netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "John W. Linville" <linville@tuxdriver.com>
To: netdev@vger.kernel.org
Cc: davem@davemloft.net, Jesse Gross <jesse@nicira.com>,
	"John W. Linville" <linville@tuxdriver.com>
Subject: [PATCH v2] geneve: remove use of internal IP header when calling IP_ECN_decapsulate
Date: Thu, 17 Sep 2015 16:34:54 -0400	[thread overview]
Message-ID: <1442522094-876-1-git-send-email-linville@tuxdriver.com> (raw)
In-Reply-To: <1442510271-10110-1-git-send-email-linville@tuxdriver.com>

This seems to have been a "thinko".  IP_ECN_decapsulate needs info
from both internal and external headers.

Signed-off-by: John W. Linville <linville@tuxdriver.com>
---
v2 -- ensure the collect_md path still calls IP_ECN_decapsulate

 drivers/net/geneve.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/geneve.c b/drivers/net/geneve.c
index da3259ce7c8d..549febac0579 100644
--- a/drivers/net/geneve.c
+++ b/drivers/net/geneve.c
@@ -126,6 +126,8 @@ static void geneve_rx(struct geneve_sock *gs, struct sk_buff *skb)
 	__be32 addr;
 	int err;
 
+	iph = ip_hdr(skb); /* outer IP header... */
+
 	if (gs->collect_md) {
 		static u8 zero_vni[3];
 
@@ -133,7 +135,6 @@ static void geneve_rx(struct geneve_sock *gs, struct sk_buff *skb)
 		addr = 0;
 	} else {
 		vni = gnvh->vni;
-		iph = ip_hdr(skb); /* Still outer IP header... */
 		addr = iph->saddr;
 	}
 
@@ -178,7 +179,6 @@ static void geneve_rx(struct geneve_sock *gs, struct sk_buff *skb)
 
 	skb_reset_network_header(skb);
 
-	iph = ip_hdr(skb); /* Now inner IP header... */
 	err = IP_ECN_decapsulate(iph, skb);
 
 	if (unlikely(err)) {
-- 
2.4.3

  parent reply	other threads:[~2015-09-17 20:45 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-17 17:17 [PATCH] geneve: remove use of internal IP header when calling IP_ECN_decapsulate John W. Linville
2015-09-17 19:46 ` Jesse Gross
2015-09-17 20:17   ` John W. Linville
2015-09-17 20:34 ` John W. Linville [this message]
2015-09-18 20:30   ` [PATCH v2] " Jesse Gross
2015-09-18 20:40     ` John W. Linville
2015-09-18 21:49       ` Jesse Gross
2015-09-19  1:36         ` John W. Linville
2015-09-19  2:19           ` Jesse Gross
2015-09-21  5:24   ` David Miller
2015-09-21 14:04     ` John W. Linville
2015-09-21 14:29     ` [PATCH v3] geneve: ensure ECN info is handled properly in all tx/rx paths John W. Linville
2015-09-22  1:11       ` Jesse Gross
2015-09-22 23:50       ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1442522094-876-1-git-send-email-linville@tuxdriver.com \
    --to=linville@tuxdriver.com \
    --cc=davem@davemloft.net \
    --cc=jesse@nicira.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).