netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Woodhouse <dwmw2@infradead.org>
To: Francois Romieu <romieu@fr.zoreil.com>
Cc: Stephen Hemminger <stephen@networkplumber.org>,
	David Miller <davem@davemloft.net>,
	netdev@vger.kernel.org
Subject: Re: [PATCH net 2/2]  8139cp: reset BQL when ring tx ring cleared
Date: Fri, 18 Sep 2015 02:04:36 +0100	[thread overview]
Message-ID: <1442538276.97487.21.camel@infradead.org> (raw)
In-Reply-To: <20150917234449.GA25782@electric-eye.fr.zoreil.com>

[-- Attachment #1: Type: text/plain, Size: 16836 bytes --]

On Fri, 2015-09-18 at 01:44 +0200, Francois Romieu wrote:
> The TxDmaOkLowDesc register may tell if the Tx dma part is still 
> making any progress. I have added a TxPoll request. See below.

I've just added that into the original TX timeout handler, since that
doesn't seem to be crashing the box for me as long as I avoid the IRQ
storm.

Not sure what we learn from it ('desc 6550' printed as hex)... I've
also made it dump the TX descriptor ring (skb, addr, opts1, opts2):

[ 1733.027156] 8139cp 0000:00:0b.0 eth1: Transmit timeout, status  c   2b head 25 tail 22 desc 6550    0 80ff
[ 1733.036819] TX ring 00:   (null) 1dd68d8c 3000cb67 0                         
[ 1733.037040] TX ring 01:   (null) 1dd8774c 3000cb67 0                         
[ 1733.037040] TX ring 02:   (null) 1dd86e7c 30000a08 0                         
[ 1733.037040] TX ring 03:   (null) 1dd865ac 30000a08 0                         
[ 1733.037040] TX ring 04:   (null) 1dd8540c 30000a08 0                         
[ 1733.037040] TX ring 05:   (null) 1dd85cdc 30000a08 0                         
[ 1733.037040] TX ring 06:   (null) 1dd84b3c 30000a08 0                         
[ 1733.037040] TX ring 07:   (null) 1dd8399c 30000a08 0                         
[ 1733.037040] TX ring 08:   (null) 1dd8426c 30000a08 0                         
[ 1733.037040] TX ring 09:   (null) 1dd830cc 30000a08 0                         
[ 1733.037040] TX ring 10:   (null) 1dd81f2c 30000a08 0                         
[ 1733.037040] TX ring 11:   (null) 1dd8165c 30000a08 0                         
[ 1733.037040] TX ring 12:   (null) 1dd827fc 30000a08 0                         
[ 1733.037040] TX ring 13:   (null) 1dd80d8c 30000a08 0                         
[ 1733.037040] TX ring 14:   (null) 1dd804bc 30000a08 0                         
[ 1733.037040] TX ring 15:   (null) 1dd6ee7c 30000a08 0                         
[ 1733.037040] TX ring 16:   (null) 1dd6f74c 30000a08 0                         
[ 1733.037040] TX ring 17:   (null) 1dd6e5ac 30000a08 0                         
[ 1733.037040] TX ring 18:   (null) 1dd6dcdc 30000a08 0                         
[ 1733.037040] TX ring 19:   (null) 1dd6cb3c 3000f804 0                         
[ 1733.037040] TX ring 20:   (null) 1dd8de02 300083da 0                         
[ 1733.037040] TX ring 21:   (null) 1dd8da02 30000000 0                         
[ 1733.037040] TX ring 22: defcc240 1dd6d40c b00005ea 0                         
[ 1733.037040] TX ring 23: decdb900 1dd6b99c b0000046 0                         
[ 1733.037040] TX ring 24: ddd27c00 1dd6b0cc b00005ea 0                         
[ 1733.037040] TX ring 25:   (null) 1dd6e5ac 3000ca24 0                         
[ 1733.037040] TX ring 26:   (null) 1dd6dcdc 3000ca24 0                         
[ 1733.037040] TX ring 27:   (null) 1dd6d40c 3000ca24 0                         
[ 1733.037040] TX ring 28:   (null) 1dd6cb3c 3000ca24 0                         
[ 1733.037040] TX ring 29:   (null) 1dd6c26c 3000ca24 0                         
[ 1733.037040] TX ring 30:   (null) 1dd6b99c 3000ca24 0                         
[ 1733.037040] TX ring 31:   (null) 1dd6b0cc 3000ca24 0                         
[ 1733.037040] TX ring 32:   (null) 1dd6a7fc 3000ca24 0                         
[ 1733.037040] TX ring 33:   (null) 1dd69f2c 3000ca24 0                         
[ 1733.037040] TX ring 34:   (null) 1dd68d8c 3000ca24 0                         
[ 1733.037040] TX ring 35:   (null) 1dd6965c 3000cb67 0                         
[ 1733.037040] TX ring 36:   (null) 1dd684bc 3000cb67 0                         
[ 1733.037040] TX ring 37:   (null) 1dd86e7c 3000cb67 0                         
[ 1733.037040] TX ring 38:   (null) 1dd8774c 3000cb67 0                         
[ 1733.037040] TX ring 39:   (null) 1dd865ac 3000cb67 0                         
[ 1733.037040] TX ring 40:   (null) 1dd85cdc 3000cb67 0                         
[ 1733.037040] TX ring 41:   (null) 1dd8540c 3000cb67 0                         
[ 1733.037040] TX ring 42:   (null) 1dd84b3c 3000cb67 0                         
[ 1733.037040] TX ring 43:   (null) 1dd8426c 3000cb67 0                         
[ 1733.037040] TX ring 44:   (null) 1dd8399c 3000cb67 0                         
[ 1733.037040] TX ring 45:   (null) 1dd830cc 3000cb67 0                         
[ 1733.037040] TX ring 46:   (null) 1dd81f2c 3000cb67 0                         
[ 1733.037040] TX ring 47:   (null) 1dd827fc 3000cb67 0                         
[ 1733.037040] TX ring 48:   (null) 1dd8165c 3000cb67 0                         
[ 1733.037040] TX ring 49:   (null) 1dd80d8c 3000cb67 0                         
[ 1733.037040] TX ring 50:   (null) 1dd804bc 3000cb67 0                         
[ 1733.037040] TX ring 51:   (null) 1dd6f74c 3000cb67 0                         
[ 1733.037040] TX ring 52:   (null) 1dd6ee7c 3000cb67 0                         
[ 1733.037040] TX ring 53:   (null) 1dd6dcdc 3000cb67 0                         
[ 1733.037040] TX ring 54:   (null) 1dd6d40c 3000cb67 0                         
[ 1733.037040] TX ring 55:   (null) 1dd6e5ac 3000cb67 0                         
[ 1733.037040] TX ring 56:   (null) 1dd6cb3c 3000cb67 0                         
[ 1733.037040] TX ring 57:   (null) 1dd6c26c 3000cb67 0                         
[ 1733.037040] TX ring 58:   (null) 1dd6b99c 3000cb67 0                         
[ 1733.037040] TX ring 59:   (null) 1dd6b0cc 3000cb67 0                         
[ 1733.037040] TX ring 60:   (null) 1dd6a7fc 3000cb67 0                         
[ 1733.037040] TX ring 61:   (null) 1dd69f2c 3000cb67 0                         
[ 1733.037040] TX ring 62:   (null) 1dd6965c 3000cb67 0                         
[ 1733.037040] TX ring 63:   (null) 1dd684bc 7000cb67 0           


And another time...
[ 3436.024610] 8139cp 0000:00:0b.0 eth1: Transmit timeout, status  c   2b head 6 tail 1 desc 1400    0 80ff                                                     
[ 3436.034101] TX ring 00:   (null) 1dc4dcdc 30000888 0                         
[ 3436.034494] TX ring 01: deffff00 1dc64e02 b000006a 0                         
[ 3436.034494] TX ring 02: ddc35180 1dc4d40c b0000036 0                         
[ 3436.034494] TX ring 03: ddc35480 1dc4cb3c b0000036 0                         
[ 3436.034494] TX ring 04: defff780 1dc4b99c b0000249 0                         
[ 3436.034494] TX ring 05: defff900 1dc4c26c b00005ea 0                         
[ 3436.034494] TX ring 06:   (null) 1dc64e02 30003c30 0                         
[ 3436.034494] TX ring 07:   (null) 1dc5165c 30003c30 0                         
[ 3436.034494] TX ring 08:   (null) 1dc64e02 30000000 0                         
[ 3436.034494] TX ring 09:   (null) 1dc64e0a 30000000 0                         
[ 3436.034494] TX ring 10:   (null) 1dc504bc 30000000 0                         
[ 3436.034494] TX ring 11:   (null) 1dc64e0a 30000000 0                         
[ 3436.034494] TX ring 12:   (null) 1dc64e02 30004881 0                         
[ 3436.034494] TX ring 13:   (null) 1dc64e0a 3000fb66 0                         
[ 3436.034494] TX ring 14:   (null) 1dc64e02 3000c031 0                         
[ 3436.034494] TX ring 15:   (null) 1dc64e02 3000c031 0                         
[ 3436.034494] TX ring 16:   (null) 1dc64e0a 30000100 0                         
[ 3436.034494] TX ring 17:   (null) 1dc64e0a 3000a684 0                         
[ 3436.034494] TX ring 18:   (null) 1dc50d8c 30000100 0                         
[ 3436.034494] TX ring 19:   (null) 1dc5f74c 30000100 0                         
[ 3436.034494] TX ring 20:   (null) 1dc64e02 30000100 0                         
[ 3436.034494] TX ring 21:   (null) 1dc64e02 30000327 0                         
[ 3436.034494] TX ring 22:   (null) 1dc64e02 30002100 0                         
[ 3436.034494] TX ring 23:   (null) 1dc64e0a 3000bd84 0                         
[ 3436.034494] TX ring 24:   (null) 1dc64e0a 30000000 0                         
[ 3436.034494] TX ring 25:   (null) 1dc64e0a 30000000 0                         
[ 3436.034494] TX ring 26:   (null) 1dc64e02 30004881 0                         
[ 3436.034494] TX ring 27:   (null) 1dc64e0a 30000a00 0                         
[ 3436.034494] TX ring 28:   (null) 1dc64e02 30000a00 0                         
[ 3436.034494] TX ring 29:   (null) 1dc64e0a 3000ed83 0                         
[ 3436.034494] TX ring 30:   (null) 1dc64e02 30009600 0                         
[ 3436.034494] TX ring 31:   (null) 1dc64e0a 30001b98 0                         
[ 3436.034494] TX ring 32:   (null) 1dc64e02 30000008 0                         
[ 3436.034494] TX ring 33:   (null) 1dc64e0a 30000000 0                         
[ 3436.034494] TX ring 34:   (null) 1dc64e02 3000dd86 0                         
[ 3436.034494] TX ring 35:   (null) 1dc64e0a 30000000 0                         
[ 3436.034494] TX ring 36:   (null) 1dc64e02 30000000 0                         
[ 3436.034494] TX ring 37:   (null) 1dc64e0a 30000000 0                         
[ 3436.034494] TX ring 38:   (null) 1dc64e02 3000b963 0                         
[ 3436.034494] TX ring 39:   (null) 1dc64e0a 30000100 0                         
[ 3436.034494] TX ring 40:   (null) 1dc64e02 3000b263 0                         
[ 3436.034494] TX ring 41:   (null) 1dc64e0a 3000b008 0                         
[ 3436.034494] TX ring 42:   (null) 1dc64e02 30000000 0                         
[ 3436.034494] TX ring 43:   (null) 1dc64e0a 30004011 0                         
[ 3436.034494] TX ring 44:   (null) 1dc64e02 30000000 0                         
[ 3436.034494] TX ring 45:   (null) 1dc64e0a 30004011 0                         
[ 3436.034494] TX ring 46:   (null) 1dc64e02 30000000 0                         
[ 3436.034494] TX ring 47:   (null) 1dc64e0a 30004011 0                         
[ 3436.034494] TX ring 48:   (null) 1dc5e5ac 30005f06 0                         
[ 3436.034494] TX ring 49:   (null) 1dc5ee7c 30002fc0 0                         
[ 3436.034494] TX ring 50:   (null) 1dc5dcdc 3000b008 0                         
[ 3436.034494] TX ring 51:   (null) 1dc5d40c 30006364 0                         
[ 3436.034494] TX ring 52:   (null) 1dc5cb3c 30006364 0                         
[ 3436.034494] TX ring 53:   (null) 1dc5c26c 30000300 0                         
[ 3436.034494] TX ring 54:   (null) 1dc5b99c 30000300 0                         
[ 3436.034494] TX ring 55:   (null) 1dc5b0cc 30003500 0                         
[ 3436.034494] TX ring 56:   (null) 1dc64e02 30000888 0                         
[ 3436.034494] TX ring 57:   (null) 1dc5a7fc 3000f1d3 0                         
[ 3436.034494] TX ring 58:   (null) 1dc59f2c 3000f1d3 0                         
[ 3436.034494] TX ring 59:   (null) 1dc5965c 3000f1d3 0                         
[ 3436.034494] TX ring 60:   (null) 1dc58d8c 3000f1d3 0                         
[ 3436.034494] TX ring 61:   (null) 1dc4f74c 30002e33 0                         
[ 3436.034494] TX ring 62:   (null) 1dc4ee7c 30002e33 0                         
[ 3436.034494] TX ring 63:   (null) 1dc4e5ac 70000888 0                         

... and another (without all the extra debugging, and without the
WARN_ON, it does seem to survive without triggering the IRQ storm)

[ 3551.027167] 8139cp 0000:00:0b.0 eth1: Transmit timeout, status  c   2b head 19 tail 16 desc 14f0    0 80ff                                                  
[ 3551.036837] TX ring 00:   (null) 1dce04bc 30000000 0                         
[ 3551.037058] TX ring 01:   (null) 1dce0d8c 30000000 0                         
[ 3551.037058] TX ring 02:   (null) 1dd6f74c 30000b66 0                         
[ 3551.037058] TX ring 03:   (null) 1dd6ee7c 30000b66 0                         
[ 3551.037058] TX ring 04:   (null) 1dd6e5ac 30000b66 0                         
[ 3551.037058] TX ring 05:   (null) 1dd6d40c 30000b66 0                         
[ 3551.037058] TX ring 06:   (null) 1dd6dcdc 30000b66 0                         
[ 3551.037058] TX ring 07:   (null) 1dd6c26c 30000000 0                         
[ 3551.037058] TX ring 08:   (null) 1dd6cb3c 30000000 0                         
[ 3551.037058] TX ring 09:   (null) 1dd6b99c 3000f804 0                         
[ 3551.037058] TX ring 10:   (null) 1dd6b0cc 30001105 0                         
[ 3551.037058] TX ring 11:   (null) 1dd6a7fc 30001105 0                         
[ 3551.037058] TX ring 12:   (null) 1dd69f2c 30001105 0                         
[ 3551.037058] TX ring 13:   (null) 1dd6965c 3000493b 0                         
[ 3551.037058] TX ring 14:   (null) 1dd68d8c 3000cea5 0                         
[ 3551.037058] TX ring 15:   (null) 1dc4f74c 30001b55 0                         
[ 3551.037058] TX ring 16: ddd2f9c0 1dd684bc b00005ea 0                         
[ 3551.037058] TX ring 17: defc76c0 1dc4e5ac b00005ea 0                         
[ 3551.037058] TX ring 18: ddd38300 1dc4ee7c b00005ea 0                         
[ 3551.037058] TX ring 19:   (null) 1dc49f2c 3000b838 0                         
[ 3551.037058] TX ring 20:   (null) 1dc48d8c 300035ae 0                         
[ 3551.037058] TX ring 21:   (null) 1dc4965c 300035ae 0                         
[ 3551.037058] TX ring 22:   (null) 1dc484bc 300085b9 0                         
[ 3551.037058] TX ring 23:   (null) 2774c 300085b9 0                            
[ 3551.037058] TX ring 24:   (null) 26e7c 300085b9 0                            
[ 3551.037058] TX ring 25:   (null) 25cdc 3000d5c4 0                            
[ 3551.037058] TX ring 26:   (null) 1dc1fe02 300025d0 0                         
[ 3551.037058] TX ring 27:   (null) 265ac 300025d0 0                            
[ 3551.037058] TX ring 28:   (null) 2540c 3000b838 0                            
[ 3551.037058] TX ring 29:   (null) 2426c 3000b838 0                            
[ 3551.037058] TX ring 30:   (null) 24b3c 3000b838 0                            
[ 3551.037058] TX ring 31:   (null) 2399c 3000b838 0                            
[ 3551.037058] TX ring 32:   (null) 230cc 3000b838 0                            
[ 3551.037058] TX ring 33:   (null) 227fc 30000040 0                            
[ 3551.037058] TX ring 34:   (null) 21f2c 30000040 0                            
[ 3551.037058] TX ring 35:   (null) 2165c 30000040 0                            
[ 3551.037058] TX ring 36:   (null) 204bc 3000b838 0                            
[ 3551.037058] TX ring 37:   (null) 20d8c 3000b838 0                            
[ 3551.037058] TX ring 38:   (null) 1dc4f74c 3000b838 0                         
[ 3551.037058] TX ring 39:   (null) 1dc4ee7c 3000b838 0                         
[ 3551.037058] TX ring 40:   (null) 1dc4dcdc 3000b838 0                         
[ 3551.037058] TX ring 41:   (null) 1dc4d40c 3000b838 0                         
[ 3551.037058] TX ring 42:   (null) 1dc4e5ac 3000b838 0                         
[ 3551.037058] TX ring 43:   (null) 1dc4c26c 3000b838 0                         
[ 3551.037058] TX ring 44:   (null) 1dc4b99c 3000b838 0                         
[ 3551.037058] TX ring 45:   (null) 1dc4cb3c 3000b838 0                         
[ 3551.037058] TX ring 46:   (null) 1dc4b0cc 30000008 0                         
[ 3551.037058] TX ring 47:   (null) 1dc4a7fc 30000008 0                         
[ 3551.037058] TX ring 48:   (null) 1dc49f2c 30000008 0                         
[ 3551.037058] TX ring 49:   (null) 1dc48d8c 30000a00 0                         
[ 3551.037058] TX ring 50:   (null) 1dc4965c 30000a00 0                         
[ 3551.037058] TX ring 51:   (null) 1dc484bc 30000a00 0                         
[ 3551.037058] TX ring 52:   (null) 1dce774c 30000a00 0                         
[ 3551.037058] TX ring 53:   (null) 1dce6e7c 30000a00 0                         
[ 3551.037058] TX ring 54:   (null) 1dce5cdc 30000a00 0                         
[ 3551.037058] TX ring 55:   (null) 1dce65ac 30000000 0                         
[ 3551.037058] TX ring 56:   (null) 1dce540c 30000000 0                         
[ 3551.037058] TX ring 57:   (null) 1dce426c 30000a66 0                         
[ 3551.037058] TX ring 58:   (null) 1dce4b3c 30000a66 0                         
[ 3551.037058] TX ring 59:   (null) 1dce399c 30000a66 0                         
[ 3551.037058] TX ring 60:   (null) 1dce30cc 30000a66 0                         
[ 3551.037058] TX ring 61:   (null) 1dce27fc 30000000 0                         
[ 3551.037058] TX ring 62:   (null) 1dce165c 30000000 0                         
[ 3551.037058] TX ring 63:   (null) 1dce1f2c 70000000 0                         



-- 
dwmw2


[-- Attachment #2: smime.p7s --]
[-- Type: application/x-pkcs7-signature, Size: 5691 bytes --]

  reply	other threads:[~2015-09-18  1:04 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-20 16:54 [PATCH net 2/2] 8139cp: reset BQL when ring tx ring cleared Stephen Hemminger
2013-05-20 21:03 ` David Miller
2013-05-20 21:37 ` Francois Romieu
2013-05-21  0:27   ` Stephen Hemminger
2015-09-14 12:05     ` David Woodhouse
2015-09-14 21:59       ` Francois Romieu
2015-09-17 11:36         ` David Woodhouse
2015-09-17 15:06           ` David Woodhouse
2015-09-17 20:44             ` Francois Romieu
2015-09-17 22:14               ` David Woodhouse
2015-09-17 23:44                 ` Francois Romieu
2015-09-18  1:04                   ` David Woodhouse [this message]
2015-09-18  7:40                     ` David Woodhouse
2015-09-18 22:42                   ` David Woodhouse
2015-09-17 12:02         ` David Woodhouse

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1442538276.97487.21.camel@infradead.org \
    --to=dwmw2@infradead.org \
    --cc=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    --cc=romieu@fr.zoreil.com \
    --cc=stephen@networkplumber.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).