From: Ursula Braun <ubraun@linux.vnet.ibm.com>
To: davem@davemloft.net
Cc: schwidefsky@de.ibm.com, heiko.carstens@de.ibm.com,
netdev@vger.kernel.org, linux-s390@vger.kernel.org,
ursula.braun@de.ibm.com, ubraun@linux.vnet.ibm.com,
Eugene Crosser <Eugene.Crosser@ru.ibm.com>
Subject: [PATCH net-next V2 1/5] qeth: remove extraneous length from %pM format
Date: Fri, 18 Sep 2015 16:06:48 +0200 [thread overview]
Message-ID: <1442585212-58347-2-git-send-email-ubraun@linux.vnet.ibm.com> (raw)
In-Reply-To: <1442585212-58347-1-git-send-email-ubraun@linux.vnet.ibm.com>
From: Eugene Crosser <Eugene.Crosser@ru.ibm.com>
Length specifier in the %pM format is not supported (at least, not
documented). Remove it, and also an extraneous '&' for the array.
Signed-off-by: Eugene Crosser <Eugene.Crosser@ru.ibm.com>
Signed-off-by: Ursula Braun <ursula.braun@de.ibm.com>
Suggested-by: Joe Perches <joe@perches.com>
---
drivers/s390/net/qeth_l2_main.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/s390/net/qeth_l2_main.c b/drivers/s390/net/qeth_l2_main.c
index a855669..a4e3652 100644
--- a/drivers/s390/net/qeth_l2_main.c
+++ b/drivers/s390/net/qeth_l2_main.c
@@ -1452,8 +1452,8 @@ static void qeth_bridge_emit_host_event(struct qeth_card *card,
env[i] = str[i]; i++;
}
if (code & IPA_ADDR_CHANGE_CODE_MACADDR) {
- snprintf(str[i], sizeof(str[i]), "MAC=%pM6",
- &addr_lnid->mac);
+ snprintf(str[i], sizeof(str[i]), "MAC=%pM",
+ addr_lnid->mac);
env[i] = str[i]; i++;
}
snprintf(str[i], sizeof(str[i]), "NTOK_BUSID=%x.%x.%04x",
--
2.3.8
next prev parent reply other threads:[~2015-09-18 14:07 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-18 14:06 [PATCH net-next V2 0/5] s390: qeth and iucv patches Ursula Braun
2015-09-18 14:06 ` Ursula Braun [this message]
2015-09-18 14:06 ` [PATCH net-next V2 2/5] qeth: no write permission for readonly sysattr Ursula Braun
2015-09-18 14:06 ` [PATCH net-next V2 3/5] qeth: move OSA portname into deprecated status Ursula Braun
2015-09-18 14:06 ` [PATCH net-next V2 4/5] qeth: add layer 2 RX/TX checksum offloading Ursula Braun
2015-09-18 14:06 ` [PATCH net-next V2 5/5] s390/iucv: do not use arrays as argument Ursula Braun
2015-09-21 23:03 ` [PATCH net-next V2 0/5] s390: qeth and iucv patches David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1442585212-58347-2-git-send-email-ubraun@linux.vnet.ibm.com \
--to=ubraun@linux.vnet.ibm.com \
--cc=Eugene.Crosser@ru.ibm.com \
--cc=davem@davemloft.net \
--cc=heiko.carstens@de.ibm.com \
--cc=linux-s390@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=schwidefsky@de.ibm.com \
--cc=ursula.braun@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).